feat(sns): add validation of displayName for topic

[sosomuse]

Issue # (if applicable)

--

Reason for this change

Display errors before deploying

Description of changes

• Implement length check for displayName (maximum 100 characters long)
  • AWS::SNS::Topic

Description of how you validated changes

I added unit tests and confirmed all tests passed.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[sosomuse]

Exemption Request: Since this change only adds validation

[go-to-k]

Thanks for this PR!

I think it is good to add the description to the property in the props.

export interface TopicProps {
  /**
   * A developer-defined string that can be used to identify this SNS topic.
   *
+  * The display name must be maximum 100 characters long, including hyphens (-),
+  * underscores (_), spaces, and tabs.
+  *
   * @default None
   */
  readonly displayName?: string;

The above message is from the documentation available in the CFn Guide.

[sosomuse]

@go-to-k
Thank you for the review!
I have added the description for displayName.

[go-to-k]

@sosomuse

Thanks! Finally, could you please change the PR title to "feat(sns): add validation of displayName for topic"?

[sosomuse]

@go-to-k
Done. Thank you for the suggestion.

[go-to-k]

Nice @sosomuse . Approved!

[xazhao]

Looks good to me. Approving. Thanks for the contribution!

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[sosomuse]

@Mergifyio update

[mergify]

update

✅ Branch has been successfully updated

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 6c15771
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.