Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDK Hotswap Feature : AWS::SQS::Queue Attribute Support #30841

Closed
naedx opened this issue Jul 12, 2024 · 7 comments
Closed

CDK Hotswap Feature : AWS::SQS::Queue Attribute Support #30841

naedx opened this issue Jul 12, 2024 · 7 comments
Assignees
Labels
@aws-cdk/aws-sqs Related to Amazon Simple Queue Service bug This issue is a bug.

Comments

@naedx
Copy link

naedx commented Jul 12, 2024

Describe the bug

A project with the L3 construct LambdaToSqsToLambda falls back to full deployments everytime because of the SQS Queue

Expected Behavior

A hotswap is perfomed.

Current Behavior

A full deployment is performed.


amplify-xxxx-xxxx-sandbox-xxxx: deploying... [1/1]
Could not perform a hotswap deployment, because the CloudFormation template could not be resolved: We don't support attributes of the 'AWS::SQS::Queue' resource. This is a CDK limitation. Please report it at https://github.com/aws/aws-cdk/issues/new/choose
Falling back to doing a full deployment
amplify-xxxx-xxxx-sandbox-xxxx: updating stack...

Reproduction Steps

  1. Create an Amplify project
  2. Add the L3 construct LambdaToSqsToLambda
  3. Deploy.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.147.0 (build 3338fc0)

Framework Version

No response

Node.js Version

20.9.0

OS

macOS 14.5, arm64

Language

TypeScript

Language Version

5.5.2

Other information

No response

@naedx naedx added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 12, 2024
@github-actions github-actions bot added the @aws-cdk/aws-sqs Related to Amazon Simple Queue Service label Jul 12, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Jul 12, 2024
@khushail khushail self-assigned this Jul 12, 2024
@khushail
Copy link
Contributor

Hey @naedx , thanks for reaching out. Could you please check if your issue is similar to this existing one -
#23533 and several others mentioned under it ?

@khushail khushail added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jul 12, 2024
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jul 14, 2024
@naedx
Copy link
Author

naedx commented Jul 15, 2024

I'll take a look at it and let you know shortly

@github-actions github-actions bot removed closing-soon This issue will automatically close in 4 days unless further comments are made. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Jul 15, 2024
@naedx
Copy link
Author

naedx commented Jul 15, 2024

Hi @khushail , I think it's related. From the thread I gathered that the cross stack references are linked to the issue occuring.

My SQS references a lambda which references a stack with S3 resources and another lambda which references a stack with AppSync/DynamoDb resources. The lambdas are declared in the stack of the resources that they reference.

I tried removing the references between the lambda and the S3 and AppSync/DynamoDB resources. Hotswap still doesn't work.

I then moved the SQS and both lambdas to the same stack and this allows hotswap to work again.

This sheds some light on the issue but it's not a workable solution for me because I cannot re-add access to my S3, AppSync/DynamoDB resources without running into a circular dependency issues.

@naedx
Copy link
Author

naedx commented Jul 15, 2024

Thank you @khushail . I'll continue following up on the thread you referenced.

@naedx naedx closed this as not planned Won't fix, can't repro, duplicate, stale Jul 15, 2024
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-sqs Related to Amazon Simple Queue Service bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

3 participants