Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Asset bundling ignored when deploy with --exclusive flag with nested stack #30967

Open
jk2l opened this issue Jul 29, 2024 · 4 comments · May be fixed by #30983
Open

core: Asset bundling ignored when deploy with --exclusive flag with nested stack #30967

jk2l opened this issue Jul 29, 2024 · 4 comments · May be fixed by #30983
Labels
@aws-cdk/aws-lambda Related to AWS Lambda @aws-cdk/core Related to core CDK functionality bug This issue is a bug. effort/medium Medium work item – several days of effort p2

Comments

@jk2l
Copy link

jk2l commented Jul 29, 2024

Describe the bug

When I run exclusive flag during deploy, the lambda within nested stack failed to do bundling

Expected Behavior

Assets bundling should executed and bundled

Current Behavior

Asset bundling ignored

Reproduction Steps

Demo example created under https://github.com/jk2l/CDK-Debug.git

if you run cdk deploy -e DEBUG-pipeline-DEV/DEV/debug the lambda lib won't be added into part of the packaging
if you run without -e you should have the lambda dependency from requirements.txt added into lambda folder structure

pre-req for running the demo: you need to put your own account id under cdk.json line 19 (replace the 000000000000)

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

v2.150.0

Framework Version

No response

Node.js Version

v18.15.0

OS

Ubuntu 22.04.1 LTS from Windows WSL

Language

Python

Language Version

Python 3.9

Other information

This may related to the following bug reports:

@jk2l jk2l added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 29, 2024
@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Jul 29, 2024
@jk2l jk2l changed the title (aws-cdk): Asset bundling ignored when deploy with --exclusive flag with nested stack core: Asset bundling ignored when deploy with --exclusive flag with nested stack Jul 30, 2024
@github-actions github-actions bot added the @aws-cdk/core Related to core CDK functionality label Jul 30, 2024
@jamcarbon
Copy link

This issue is also happening to me on Ubuntu 20 with Python 12.

@jk2l
Copy link
Author

jk2l commented Jul 31, 2024

found the root cause, submitted a PR

@pahud
Copy link
Contributor

pahud commented Jul 31, 2024

Thank you for the report and PR! We'll take a look when it's ready.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jul 31, 2024
@jk2l
Copy link
Author

jk2l commented Jul 31, 2024

@pahud I have updated the PR, but it is asking for Integration test which there isn't existing one for core. also i am not sure how is it to setup one for this. I think unit test should be sufficient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-lambda Related to AWS Lambda @aws-cdk/core Related to core CDK functionality bug This issue is a bug. effort/medium Medium work item – several days of effort p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants