Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InstanceProps: Unable to set CACertificateIdentifier #31042

Open
2 tasks
farazoman opened this issue Aug 6, 2024 · 4 comments
Open
2 tasks

InstanceProps: Unable to set CACertificateIdentifier #31042

farazoman opened this issue Aug 6, 2024 · 4 comments
Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@farazoman
Copy link

Describe the feature

Following this issue: aws-cloudformation/cloudformation-coverage-roadmap#211 ability to set the CACertificateIdentifier was supported in Cloudformation, which i see is also supported in the DBInstance type in CDK. The issue is that if someone wants to use InstanceProps, they have no way via CDK to fix the issue.

Use Case

When regularly needing to update cert auth identifiers via CDK with InstanceProps, there is no way to do so.

Proposed Solution

allow passing the CACertificateIdentifier property to avoid drift in infra code vs actual infra

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.118.0 (build a40f2ec)

Environment details (OS name and version, etc.)

MacOS, Sonoma 14.6...

@farazoman farazoman added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 6, 2024
@farazoman farazoman changed the title InstanceProps: (short issue description) InstanceProps: Unable to set CACertificateIdentifier Aug 6, 2024
@github-actions github-actions bot added the @aws-cdk/aws-cloudformation Related to AWS CloudFormation label Aug 6, 2024
@ashishdhingra
Copy link
Contributor

@farazoman Good afternoon. Thanks for opening the issue. Could you please elaborate your scenario with a code example.

Please advise if you are unable to use caCertificate property (which is ultimately used for setting caCertificateIdentifier property).

Thanks,
Ashish

@ashishdhingra ashishdhingra added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. p3 and removed needs-triage This issue or PR still needs to be triaged. labels Aug 6, 2024
@ashishdhingra ashishdhingra self-assigned this Aug 6, 2024
@farazoman
Copy link
Author

@ashishdhingra , thanks for responding, so the construction of the db is something like this:

rds.DatabaseCluster(this, 'Cluster', {
      ...(identifier props)
      instanceProps: instanceProps,
      instances: instances,
}

so I am constructing the instance via a cluster by specifying the number of instances I want.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Aug 7, 2024
@ashishdhingra
Copy link
Contributor

@farazoman Thanks for your response. So looks like you are requesting to add support for setting caCertificateIdentifier for the instances created while defining DatabaseCluster. Is this correct? If yes, we would perhaps need to add support for caCertificate property in L2 DatabaseCluster properties and use it when creating instances in legacyCreateInstances and/or _createInstances() (we might need to add support in IAuroraClusterInstance).

@ashishdhingra ashishdhingra added p2 effort/medium Medium work item – several days of effort and removed p3 labels Aug 12, 2024
@ashishdhingra ashishdhingra removed their assignment Aug 12, 2024
@farazoman
Copy link
Author

Yes exactly what I am looking for. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

2 participants