feat(synthetics): add syn-python-selenium-4.0 runtime #31101
Conversation
github-actions
bot
added
effort/small
github-actions
bot
added
the
distinguished-contributor
|
Exemption Request: I think updating the README is unnecessary, as this only involves adding a value to an enum. |
aws-cdk-automation
added
the
pr-linter/exemption-requested
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
| @@ -224,7 +224,7 @@ test('Python runtime can be specified', () => { | |||
|
|
|||
| // WHEN | |||
| new synthetics.Canary(stack, 'Canary', { | |||
| runtime: synthetics.Runtime.SYNTHETICS_PYTHON_SELENIUM_2_0, | |||
| runtime: synthetics.Runtime.SYNTHETICS_PYTHON_SELENIUM_4_0, | |||
There was a problem hiding this comment.
Since syn-python-selenium-2.0 is already deprecated, I've decided to make modifications at this time.
https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_python_selenium.html#CloudWatch_Synthetics_runtimeversion-syn-python-selenium-2.0
aws-cdk-automation
added
the
pr/needs-community-review
aws-cdk-automation
added
pr/needs-maintainer-review
xazhao
added
the
pr-linter/exempt-readme
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #30137.
Reason for this change
Add new runtime.
https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_python_selenium.html#CloudWatch_Synthetics_runtimeversion-syn-python-selenium-4.0
Description of changes
Add
syn-python-selenium-4.0for synthetics runtime ENUM.Description of how you validated changes
Modify a unit test and an integ test to test the new runtime.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license