-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ecs.ExternalService: daemon
and placementConstraints
not implemented
#31204
Labels
@aws-cdk/aws-ecs
Related to Amazon Elastic Container
bug
This issue is a bug.
effort/medium
Medium work item – several days of effort
p2
Comments
mattstam
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Aug 23, 2024
github-actions
bot
added
the
@aws-cdk/aws-ecs
Related to Amazon Elastic Container
label
Aug 23, 2024
mattstam
changed the title
ecs.ExternalService: daemon and placementConstraints not implemented
ecs.ExternalService: Aug 23, 2024
daemon
and placementConstraints
not implemented
ashishdhingra
added
p2
investigating
This issue is being investigated and/or work is in progress to resolve the issue.
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Aug 23, 2024
Perhaps we need to add support of these properties in |
ashishdhingra
added
effort/medium
Medium work item – several days of effort
and removed
investigating
This issue is being investigated and/or work is in progress to resolve the issue.
labels
Aug 23, 2024
Thanks for the overview @ashishdhingra - based on the proposed implementation steps, do you have an ETA on when this could be added? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-ecs
Related to Amazon Elastic Container
bug
This issue is a bug.
effort/medium
Medium work item – several days of effort
p2
Describe the bug
Extension of this: aws/containers-roadmap#2395
I would like to enable daemon-type scheduling for services running on External instances through ECS-Anywhere. If the
daemon
boolean option is not available, then a workaround would simply to be to do useplacementConstraints
with theDistinctInstance
option.At first, it appeared as if this was unsupported on ECS External services in AWS. However, it appears that placement constraints are already supported in AWS, but just not added to the CDK client - I believe this is the case because if I go edit an existing
ecs.ExternalService
on the console, I have the option to add placement constraints, but if I use the CDK, it is not an option and gives the following errors when I try on either the External Task Definition or External Service:I think a simple fix here is to simply add those fields on either of the
ecs.ExternalTaskDefition
orecs.ExternalService
types. Longer-term, adaemon
option might be nice, but as I understand it, this is basically just syntax sugar aroundplacementConstraints: distinctInstance()
?Regression Issue
Last Known Working CDK Version
No response
Expected Behavior
I would expect this:
or this:
to work.
Current Behavior
Those fields are not available.
Reproduction Steps
To reproduce, try the code in the expected behavior
Possible Solution
It's already added to AWS it seems, so in the CDK we just need to add the fields
Additional Information/Context
No response
CDK CLI Version
2.130.0 (build bd6e5ee)
Framework Version
No response
Node.js Version
20
OS
Ubuntu
Language
TypeScript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: