Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch: Add support for multiple container jobs on ECS (EcsProperties) to MultiNodeJobDefinition #31243

Open
1 of 2 tasks
delagoya opened this issue Aug 28, 2024 · 1 comment
Open
1 of 2 tasks
Labels
@aws-cdk/aws-batch Related to AWS Batch effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@delagoya
Copy link

Describe the feature

AWS Batch now supports multiple containers in a single job definition. For multi-node parallel jobs, this means that MultiNodeJobDefinition L2 construct would need to support two new properties that stem from the NodeRangePropertyProperty L1 construct:

  1. readonly ecsProperties: IEcsContainerDefintion
  2. readonly eksProperties: EksContainerDefinition

Note that (2) is encapsulated in issue #30906

Use Case

To be able to define multiple containers in MNP job definitions across both ECS and EKS clusters with AWS Batch

Proposed Solution

Possible actions are to:

  1. create a new classes for supporting multi-container jobs on ECS and EKS
    a. , MultiNodeEcsJobDefinition for ECS
    b. MultiNodeEksJobDefintion for EKS (as mentioned in batch: support multi-node job on Amazon EKS #30906 )
  2. add a new property, NodeRanges, that aligns closer to the current Batch API.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.154.1

Environment details (OS name and version, etc.)

all

@delagoya delagoya added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 28, 2024
@github-actions github-actions bot added the @aws-cdk/aws-batch Related to AWS Batch label Aug 28, 2024
@khushail
Copy link
Contributor

@delagoya , Thanks for reaching out and checking on the updates for the cloudformation support for L1 construct. .

@khushail khushail added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-batch Related to AWS Batch effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

2 participants