fix(cli): bootstrap respects qualifier from cdk.json

[kaizencc]

closes #28249.

The qualifier property can be set via the context key "@aws-cdk/core:bootstrapQualifier" and if omitted, the arbitrary default is hnb659fds. In the case of cdk bootstrap, there is an additional way to set the qualifier via the --qualifier CLI option. Specific to the cdk bootstrap logic, we currently only honor the command line argument, which is an error.

Ultimately, the following cdk bootstrap calls should be identical:

• cdk bootstrap with the following cdk.json file:

{
  "@aws-cdk/core:bootstrapQualifier": "abcde",
}

• cdk bootstrap --qualifier="abcde"

I've made the decision that the --qualifier parameter takes precedent over the cdk.json context if they are both set.

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[mrgrain]

I've made the decision that the --qualifier parameter takes precedent over the cdk.json context if they are both set but I can see a reasonable argument for throwing an error too

@kaizencc That's usually how it's done. But to confirm, how do other flags work?

Also the issue expects cdk.json to work. But you say you are fixing it for context.json? Can you clarify please.

[aws-cdk-automation]

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

[kaizencc]

I mean cdk.json, sorry. Although all places we add context goes into the same Configuration object so in theory it should work for both cdk.json and cdk.context.json.

[kaizencc]

The only other place in cli.ts where I see two ways of describing the same thing is here:

case 'synth':
        const quiet = configuration.settings.get(['quiet']) ?? args.quiet;

and it is in fact defaulting to the opposite. But this line was written by a community contributor and it doesn't look like that decision was made with any intentionality (and in fact maybe was done to make testing easier). I think we should default to command line arguments before context values and would support switching the quiet logic around also.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: ff55718
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.