Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bedrock): support meta llama3-2 #31568

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Sep 26, 2024

Issue # (if applicable)

Closes #.

Reason for this change

Added Meta Llama 3.2 models.

  • meta.llama3-2-1b-instruct-v1:0
  • meta.llama3-2-3b-instruct-v1:0
  • meta.llama3-2-11b-instruct-v1:0
  • meta.llama3-2-90b-instruct-v1:0

ref

Description of changes

Added the models.

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 26, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team September 26, 2024 06:13
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Sep 26, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 26, 2024
Copy link
Contributor

@sumupitchayan sumupitchayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR - can you validate these changes by adding these newly supported models to an existing integ test and update the snapshots? Just to confirm that it deploys - also a nit, I think this should be a feat instead of a chore

@go-to-k go-to-k changed the title chore(bedrock): support meta llama3-2 feat(bedrock): support meta llama3-2 Sep 26, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 26, 2024
@go-to-k
Copy link
Contributor Author

go-to-k commented Sep 26, 2024

@sumupitchayan

can you validate these changes by adding these newly supported models to an existing integ test and update the snapshots?

Integ tests don't yet appear to exist in the bedrock module, and there is no a directory for bedrock in the @aws-cdk-testing module. What should I do?

@go-to-k
Copy link
Contributor Author

go-to-k commented Sep 26, 2024

Exemption Request: This PR just adds models as enum.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Sep 26, 2024
@go-to-k
Copy link
Contributor Author

go-to-k commented Sep 26, 2024

Oh, I found in SFn tasks module! I will add to the test.

https://github.com/go-to-k/aws-cdk/blob/9ddfe788283e1b42508299e3f9cc2ea3aae5134f/packages/@aws-cdk-testing/framework-integ/test/aws-stepfunctions-tasks/test/bedrock/integ.invoke-model.ts#L16

@go-to-k
Copy link
Contributor Author

go-to-k commented Sep 26, 2024

@sumupitchayan

Updated and run.

@sumupitchayan sumupitchayan added pr-linter/exempt-readme The PR linter will not require README changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Sep 26, 2024
Copy link
Contributor

@sumupitchayan sumupitchayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the test!

@aws-cdk-automation aws-cdk-automation dismissed their stale review September 26, 2024 16:15

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@go-to-k
Copy link
Contributor Author

go-to-k commented Sep 26, 2024

@Mergifyio update

Copy link
Contributor

mergify bot commented Sep 26, 2024

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: adee8bb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Sep 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4ddc702 into aws:main Sep 26, 2024
9 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2024
@go-to-k go-to-k deleted the bedrock-llama-32 branch September 26, 2024 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants