-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scheduler-alpha): remove targetOverrides
prop from Schedule
#31799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
targetOverrides
prop from ScheduletargetOverrides
prop from Schedule
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
557fe80
to
1e2d06e
Compare
/** | ||
* The customer managed KMS key that EventBridge Scheduler will use to encrypt and decrypt your data. | ||
*/ | ||
readonly key?: kms.IKey; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we mean to remove this key
property as part of this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Removing it from the interface as it is not being used currently. I would like to start with minimal exposed APIs, then we can add more in the future if needed.
@@ -285,25 +285,6 @@ const target = new targets.LambdaInvoke(fn, { | |||
}); | |||
``` | |||
|
|||
## Overriding Target Properties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know if this is a common use case? If so it may be worth keeping this README section with your updated suggestion for overriding target props
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is common use case. If we see the need in the future, we can add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Tracking: #31785
Reason for this change
The
targetOverrides
prop is adding confusion to the API as it override what is set on the target. A better way to reuse target props would be:Description of changes
Removed
targetOverrides
prop and the related tests. Also updated the integ test which was using the prop.Description of how you validated changes
Removing a prop so n/a.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
BREAKING CHANGE: This PR removes the
targetOverrides
prop from theSchedule
construct.