Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolicyStatementProps should accept Effect. #3195

Closed
nikamipara opened this issue Jul 4, 2019 · 1 comment
Closed

PolicyStatementProps should accept Effect. #3195

nikamipara opened this issue Jul 4, 2019 · 1 comment
Labels
needs-triage This issue or PR still needs to be triaged.

Comments

@nikamipara
Copy link

Note: for support questions, please first reference our documentation, then use Stackoverflow. This repository's issues are intended for feature requests and bug reports.

  • I'm submitting a ...

    • [X ] 🪲 bug report
  • What is the current behavior?
    If the current behavior is a 🪲bug🪲: Please provide the steps to reproduce
    As per Current Behaviour to set allow policy on on say dummy action we have to write following.

var policy = new PolicyStatement(PolicyStatementProps.builder()
.withActions(List.of("dummy_action"))
.build()
);
policy.setEffect(Effect.ALLOW);
  • What is the expected behavior (or behavior of feature suggested)?
    Expected is following.
var policy = new PolicyStatement(PolicyStatementProps.builder()
.withActions(List.of("dummy_action"))
.withEffect(Effect.ALLOW)
.build()
);
  • What is the motivation / use case for changing the behavior or adding this feature?

  • Please tell us about your environment:

    • CDK CLI Version: 00.36.00
    • Module Version: xx.xx.xx
    • OS: [all | Windows 10 | OSX Mojave | Ubuntu | etc... ]
    • Language: [all | TypeScript | Java | Python ]
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. associated pull-request, stackoverflow, gitter, etc)

@nikamipara nikamipara added the needs-triage This issue or PR still needs to be triaged. label Jul 4, 2019
@nikamipara nikamipara changed the title PolicyStatementProps should take Effect. PolicyStatementProps should accept Effect. Jul 4, 2019
@rix0rrr
Copy link
Contributor

rix0rrr commented Jul 5, 2019

Fixed in #3165

@rix0rrr rix0rrr closed this as completed Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants