Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk): use built-in source map support #32115

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Nov 13, 2024

Reason for this change

We don't need to use the third party source-map-support package anymore to achieve the same result.

Description of changes

We use process.setSourceMapsEnabled(true) instead. However unlike the previous package, this command needs to be run before we import any other files, otherwise it won't work. We therefore move it into the executable.

Description of how you validated changes

Manual verification

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Nov 13, 2024
@github-actions github-actions bot added the p2 label Nov 13, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 13, 2024 19:44
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 13, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Nov 13, 2024
@mrgrain mrgrain force-pushed the mrgrain/fix/cli/use-node-source-maps branch from 5c2d3ad to b24306d Compare November 14, 2024 09:35
@mrgrain mrgrain force-pushed the mrgrain/fix/cli/use-node-source-maps branch from b24306d to a0d49f9 Compare November 14, 2024 09:46
@mrgrain mrgrain changed the title fix(cdk): use not built-in source map support fix(cdk): use built-in source map support Nov 14, 2024
@mrgrain mrgrain force-pushed the mrgrain/fix/cli/use-node-source-maps branch from 0fdf526 to 333104b Compare November 14, 2024 11:55
@mrgrain mrgrain force-pushed the mrgrain/fix/cli/use-node-source-maps branch from 333104b to fd88b1e Compare November 14, 2024 12:06
@mrgrain mrgrain marked this pull request as ready for review November 14, 2024 12:23
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.17%. Comparing base (9ef4e72) to head (22744c4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #32115      +/-   ##
==========================================
+ Coverage   77.15%   77.17%   +0.01%     
==========================================
  Files         105      105              
  Lines        7165     7162       -3     
  Branches     1312     1311       -1     
==========================================
- Hits         5528     5527       -1     
+ Misses       1457     1455       -2     
  Partials      180      180              
Flag Coverage Δ
suite.unit 77.17% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 77.17% <ø> (+0.01%) ⬆️

@mrgrain mrgrain marked this pull request as draft November 14, 2024 13:49
@mrgrain mrgrain force-pushed the mrgrain/fix/cli/use-node-source-maps branch from c15b09b to 8b0df3d Compare November 14, 2024 14:13
@mrgrain mrgrain marked this pull request as ready for review November 14, 2024 14:14
@mrgrain mrgrain removed the pr/needs-cli-test-run This PR needs CLI tests run against it. label Nov 14, 2024
@mrgrain mrgrain added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Nov 14, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 14, 2024 14:16

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Nov 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot temporarily deployed to test-pipeline November 14, 2024 14:45 Inactive
Copy link
Contributor

mergify bot commented Nov 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mrgrain
Copy link
Contributor Author

mrgrain commented Nov 14, 2024

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Nov 14, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 22744c4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5d499dc into main Nov 14, 2024
16 of 17 checks passed
Copy link
Contributor

mergify bot commented Nov 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the mrgrain/fix/cli/use-node-source-maps branch November 14, 2024 16:14
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants