Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ses: allow ConfigurationSet to disable suppression list #32149

Closed
1 of 2 tasks
Tietew opened this issue Nov 15, 2024 · 3 comments · Fixed by #32168
Closed
1 of 2 tasks

ses: allow ConfigurationSet to disable suppression list #32149

Tietew opened this issue Nov 15, 2024 · 3 comments · Fixed by #32168
Labels
@aws-cdk/aws-ses Related to Amazon Simple Email Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@Tietew
Copy link
Contributor

Tietew commented Nov 15, 2024

Describe the feature

ConfigurationSet have a option to override suppression list settings.
AWS console allows us to disable suppression list:
image

But ConfigurationSet L2 construct only allows to specify one or more supression reasons.
CloudFormation supports to disable suppression list by specifying SuppressionOptions.SuppressionReasons resource property to [] (empty array).

Use Case

Disabling suppression list allows us to send an e-mail to already suppressed (in account-level suppression list) destinations.
This behavior is useful to send verification code to verify whether an e-mail address is reachable.

Proposed Solution

Introduce disableSuppressionList property.

Usage:

// disable suppression list
new ses.ConfigurationSet(this, 'ConfigurationSet', {
  disableSuppressionList: true,
});

// default - account-level suppression settings will be used
new ses.ConfigurationSet(this, 'ConfigurationSet', {
  disableSuppressionList: false,
});

// error - suppressionReasons must be absent
new ses.ConfigurationSet(this, 'ConfigurationSet', {
  disableSuppressionList: true,
  suppressionReasons: ses.SuppressionReasons.BOUNCE,
});

// redundant but allowed - override suppression reasons
new ses.ConfigurationSet(this, 'ConfigurationSet', {
  disableSuppressionList: false,
  suppressionReasons: ses.SuppressionReasons.BOUNCE,
});

Other Information

AWS Documentation: Using configuration set-level suppression to override your account-level suppression list
https://docs.aws.amazon.com/ses/latest/dg/sending-email-suppression-list-config-level.html

Escape hatch available:

const configurationSet = new ses.ConfigurationSet(this, 'ConfigurationSet');
(configurationSet.node.defaultChild as ses.CfnConfigurationSet).addPropertyOverride('SuppressionOptions.SuppressedReasons', []);

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.166.0

Environment details (OS name and version, etc.)

Linux

@Tietew Tietew added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 15, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ses Related to Amazon Simple Email Service label Nov 15, 2024
@khushail khushail added needs-reproduction This issue needs reproduction. p2 and removed needs-triage This issue or PR still needs to be triaged. labels Nov 15, 2024
@khushail khushail self-assigned this Nov 15, 2024
@khushail
Copy link
Contributor

khushail commented Nov 16, 2024

Hi @Tietew , thanks for requesting this. I agree , having a flag or property would have been easier option than manually overrriding the L1 construct property -https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ses.CfnConfigurationSet.SuppressionOptionsProperty.html#suppressedreasons.
Thanks for volunteering for contribution. Looking forward to it!

@khushail khushail added effort/small Small work item – less than a day of effort and removed needs-reproduction This issue needs reproduction. labels Nov 16, 2024
@khushail khushail removed their assignment Nov 16, 2024
@GavinZZ GavinZZ closed this as completed in bb50c1a Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
Copy link

github-actions bot commented Dec 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-ses Related to Amazon Simple Email Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants