fix(elasticloadbalancingv2): cannot create UDP listener for dual-stack NLB

[badmintoncryer]

Issue # (if applicable)

None

Reason for this change

NetworkListener has the validation that it does not create UDP listeners for dual-stack NLB.

However, dual-stack NLB now supports the creation of UDP listeners, and this validation is no longer required.

https://aws.amazon.com/about-aws/whats-new/2024/10/aws-udp-privatelink-dual-stack-network-load-balancers/?nc1=h_ls

Description of changes

• Remove this validation from NetworkListener class.

    if (
      props.loadBalancer.ipAddressType === IpAddressType.DUAL_STACK &&
      (props.protocol === Protocol.UDP || props.protocol === Protocol.TCP_UDP)
    ) {
      throw new Error('UDP or TCP_UDP listeners cannot be added to a dualstack network load balancer.');
    }

• Add enablePrefixIpv6SourceNat to the NetworkLoadbalancerProps
  • It is essential to enable this parameter for UDP listener with dual-stack NLB.
  • ref: fix(elasticloadbalancingv2): cannot create UDP listener for dual-stack NLB #32184 (comment)

Description of how you validated changes

Add both unit and integ tests.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[badmintoncryer]

Exemption request
This change does not require a snapshot update.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.67%. Comparing base (5ada161) to head (ae3d215).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #32184      +/-   ##
==========================================
+ Coverage   78.66%   78.67%   +0.01%     
==========================================
  Files         107      107              
  Lines        7237     7237              
  Branches     1329     1329              
==========================================
+ Hits         5693     5694       +1     
+ Misses       1358     1357       -1     
  Partials      186      186              

Flag	Coverage Δ
suite.unit	78.67% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	78.67% <ø> (+0.01%)	⬆️

[GavinZZ]

Thank you for making the change! Can you add an integration test to test the deployability with UDP as protocol?

[badmintoncryer]

Memo:I'll try to make EnablePrefixForIpv6SourceNat configurable at L2.

integ test:

import * as ec2 from 'aws-cdk-lib/aws-ec2';
import * as integ from '@aws-cdk/integ-tests-alpha';
import * as elbv2 from 'aws-cdk-lib/aws-elasticloadbalancingv2';
import { App, Stack } from 'aws-cdk-lib';

const app = new App();
const stack = new Stack(app, 'DualstackNlbUdpListenerStack');

const vpc = new ec2.Vpc(stack, 'Vpc', {
  restrictDefaultSecurityGroup: false,
  maxAzs: 2,
  ipProtocol: ec2.IpProtocol.DUAL_STACK,
});

const nlb = new elbv2.NetworkLoadBalancer(stack, 'Nlb', {
  vpc,
  ipAddressType: elbv2.IpAddressType.DUAL_STACK,
});

const targetGroup = new elbv2.NetworkTargetGroup(stack, 'TargetGroup', {
  vpc,
  port: 12345,
  protocol: elbv2.Protocol.UDP,
});

const listener = new elbv2.NetworkListener(stack, 'Listener', {
  loadBalancer: nlb,
  port: 12345,
  protocol: elbv2.Protocol.UDP,
});
listener.addTargetGroups('TargetGroups', targetGroup);

new integ.IntegTest(app, 'DualstackNlbUdpListenerInteg', {
  testCases: [stack],
});

Result:

Failed resources:
DualstackNlbUdpListenerStack | 12:58:17 PM | CREATE_FAILED        | AWS::ElasticLoadBalancingV2::Listener     | Listener (Listener828B0E81) Resource handler returned message: "The specified listener protocol 'UDP' is not supported on load balancers using the 'dualstack' IP address type when 'EnablePrefixForIpv6SourceNat' is set to 'off' (Service: ElasticLoadBalancingV2, Status Code: 400, Request ID: 9bde532a-65ee-4d3c-b7f8-dd4226cf00aa)" (RequestToken: f44f72f5-c3f2-c539-ea85-986635ad31eb, HandlerErrorCode: InvalidRequest)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Pull request has been modified.

[GavinZZ]

Thank you for all the effort! Approved this PR.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[badmintoncryer]

@GavinZZ Thanks always!!

[badmintoncryer]

@mergify update

[mergify]

update

☑️ Nothing to do

• queue-position = -1 [📌 update requirement]
• #commits-behind > 0 [📌 update requirement]
• -closed [📌 update requirement]
• -conflict [📌 update requirement]

[mergify]

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

• ❌ codecov/project
• ❌ codecov/project/packages/aws-cdk
• 🟠 AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

[badmintoncryer]

@mergify update

[mergify]

update

☑️ Nothing to do

• #commits-behind > 0 [📌 update requirement]
• -closed [📌 update requirement]
• -conflict [📌 update requirement]
• queue-position = -1 [📌 update requirement]

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[badmintoncryer]

@mergify update

[mergify]

update

✅ Branch has been successfully updated

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[badmintoncryer]

@mergify update

[mergify]

update

☑️ Nothing to do

• #commits-behind > 0 [📌 update requirement]
• -closed [📌 update requirement]
• -conflict [📌 update requirement]
• queue-position = -1 [📌 update requirement]

[badmintoncryer]

@mergify update

[mergify]

update

☑️ Nothing to do

• #commits-behind > 0 [📌 update requirement]
• -closed [📌 update requirement]
• -conflict [📌 update requirement]
• queue-position = -1 [📌 update requirement]

[badmintoncryer]

@mergify update

[mergify]

update

✅ Branch has been successfully updated

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: ae3d215
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.