Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: short-lived credentials are not refreshed #32287

Closed
rix0rrr opened this issue Nov 26, 2024 · 4 comments · Fixed by #32354
Closed

CLI: short-lived credentials are not refreshed #32287

rix0rrr opened this issue Nov 26, 2024 · 4 comments · Fixed by #32354
Assignees
@otaviomacedo
Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort p2 package/tools Related to AWS CDK Tools or CLI

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 26, 2024 •
edited
Loading

Describe the bug

If Role credentials are only valid for 15 minutes, and a deploy operation takes longer than that, the operation should complete successfully.

Make sure that credentials are correctly refreshed by the SDK.
@rix0rrr rix0rrr added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 26, 2024
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Nov 26, 2024
@ashishdhingra
Copy link
Contributor

Opened by CDK team. Marking it as p2.

@ashishdhingra ashishdhingra added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 26, 2024
@github-actions github-actions bot mentioned this issue Dec 1, 2024
Open
@rix0rrr
Copy link
Contributor Author

rix0rrr commented Dec 2, 2024 •
edited
Loading

We have a customer being hit by this, stacks take >1hr to deploy and assume role credentials time out.

Internal reference D181861042

I'm pretty sure double-role-chaining should always exhibit this problem even quicker as they cannot have a lifetime of >15 minutes.

@rix0rrr rix0rrr changed the title CLI: confirm that short-lived credentials get refreshed CLI: short-lived credentials are not refreshed Dec 2, 2024
@rix0rrr rix0rrr mentioned this issue Dec 2, 2024
Merged
@rix0rrr rix0rrr closed this as completed in 058a0bf Dec 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@otaviomacedo otaviomacedo

Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli): short-lived credentials are not refreshed aws/aws-cdk
3 participants
@otaviomacedo @rix0rrr @ashishdhingra