Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-eks] Managed NodeGroup diskType support #32372

Open
1 of 2 tasks
bramk opened this issue Dec 3, 2024 · 1 comment
Open
1 of 2 tasks

[aws-eks] Managed NodeGroup diskType support #32372

bramk opened this issue Dec 3, 2024 · 1 comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p1

Comments

@bramk
Copy link

bramk commented Dec 3, 2024

Describe the feature

Allow specifying volume type for root volumes of Managed NodeGroup EC2 instances.

Use Case

We want to move away from gp2 and use gp3 root devices when using EKS Managed NodeGroups.

Proposed Solution

Add a ‎EbsDeviceVolumeType? parameter "diskType" in managed-nodegroup that can override the current default gp2.

Other Information

There already is "diskSize". Also closely related to #9006.

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.170.0

Environment details (OS name and version, etc.)

EKS 1.30 with standard AMIs

@bramk bramk added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 3, 2024
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Dec 3, 2024
@khushail
Copy link
Contributor

khushail commented Dec 3, 2024

Hi @bramk , thanks for requesting this. Currently, this diskType is not supported by Cloudformation as can be seen here -https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-eks-nodegroup.html#aws-resource-eks-nodegroup-properties.

but I also see this suggestion of providing support in case of EBS Encryption - #9006 (comment) and using the EC2.LaunchTemplate for the same(same scenario holds true for NodeGroup DiskType AFAIU). So I think you might have to do the same as a workaround by incorporating the change in line.

So in this regard, I would mark this issue for input by the Core team for an approval on the process if this is something on their radar for future work or if they would like to share insights on the suggested mode of action.Hope that helps!

Thanks

@khushail khushail added p1 effort/medium Medium work item – several days of effort needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. and removed needs-triage This issue or PR still needs to be triaged. labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p1
Projects
None yet
Development

No branches or pull requests

2 participants