feat(ses): configurationset support default event bus and firehose as destination

[phuhung273]

Issue # (if applicable)

Closes #32835
Closes #30671

Reason for this change

ConfigurationSet doesn't support EventBridge, Firehose as destination

Description of changes

ConfigurationSet destination support:

• Firehose
• default EventBus

Description of how you validated changes

Unit + integration

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.16%. Comparing base (0379878) to head (3130f0e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33093   +/-   ##
=======================================
  Coverage   82.16%   82.16%           
=======================================
  Files         119      119           
  Lines        6857     6857           
  Branches     1157     1157           
=======================================
  Hits         5634     5634           
  Misses       1120     1120           
  Partials      103      103           

Flag	Coverage Δ
suite.unit	82.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	∅ <ø> (∅)
packages/aws-cdk-lib/core	82.16% <ø> (ø)

[lpizzinidev]

Thanks for the PR 👍 Left a comment to discuss the implementation.
Also, are you planning to add the Firehose destination as well?

[phuhung273]

I want to add Firehose also but I simply dont know how :(

Since there is no helper interface and Firehose still not have L2 construct, Im thinking about adding another interface like this CloudWatch

aws-cdk/packages/aws-cdk-lib/aws-ses/lib/configuration-set-event-destination.ts

Lines 165 to 182 in af44791

	export interface CloudWatchDimension {
	/**
	* The place where Amazon SES finds the value of a dimension to publish to
	* Amazon CloudWatch.
	*/
	readonly source: CloudWatchDimensionSource;
	/**
	* The name of an Amazon CloudWatch dimension associated with an email sending metric.
	*/
	readonly name: string;
	/**
	* The default value of the dimension that is published to Amazon CloudWatch
	* if you do not provide the value of the dimension when you send an email.
	*/
	readonly defaultValue: string;
	}

Can you help suggest @lpizzinidev ? If yes I will try to include Firehose also.

[lpizzinidev]

I want to add Firehose also but I simply dont know how :(

DeliveryStream V2 was merged a few days ago.
You should be able to implement it using the construct.

[phuhung273]

DeliveryStream V2 was merged a few days ago. You should be able to implement it using the construct.

Thanks for the good news, Firehose added.

[aws-cdk-automation]

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[aws-cdk-automation]

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[lpizzinidev]

Thanks 👍

[phuhung273]

Thanks for your review @lpizzinidev 👍

[GavinZZ]

LGTM, thank you!

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

[GavinZZ]

@Mergifyio requeue

[mergify]

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

[mergify]

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #33093 has been manually updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Pull request has been modified.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 3130f0e
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.