Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomResource applies presumptuous property uppercasing #3421

Closed
1 of 5 tasks
briancoit opened this issue Jul 24, 2019 · 4 comments
Closed
1 of 5 tasks

CustomResource applies presumptuous property uppercasing #3421

briancoit opened this issue Jul 24, 2019 · 4 comments
Assignees
@eladb
Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md

Comments

@briancoit
Copy link

briancoit commented Jul 24, 2019 •
edited by SomayaB
Loading

Uppercasing is applied to the first character of a provided parameter name. This seems very opinionated, and is not mirrored by the existing Cloudformation behavior.

  • What is the expected behavior (or behavior of feature suggested)?
    No transformation is applied.

  • What is the motivation / use case for changing the behavior or adding this feature?
    In our case, we have an existing lambda which accepts some parameters, which are currently lowercase. Migrating to CDK requires an update to the deployed lambda code - which our team does not own. This behavior is not documented outside code (from what I can see), and what has been documented does not seem to serve as any real justification for the transformation.

  • Please tell us about your environment:

    • CDK CLI Version: 1.1.0
    • Module Version: 1.1.0
    • OS: all
    • Language: TypeScript
@briancoit briancoit added the needs-triage This issue or PR still needs to be triaged. label Jul 24, 2019
@eladb eladb added feature-request A feature should be added or improved. @aws-cdk/aws-cloudformation Related to AWS CloudFormation labels Aug 13, 2019
@eladb eladb self-assigned this Aug 13, 2019
@SomayaB
Copy link
Contributor

SomayaB commented Oct 11, 2019

Hi @briancoit, thanks for submitting a feature request! We will look into this and someone will update this issue when there is movement.

@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Oct 11, 2019
@eladb
Copy link
Contributor

eladb commented Jan 23, 2020

MUST BE FIXED

@eladb eladb added the effort/small Small work item – less than a day of effort label Jan 23, 2020
@eladb
Copy link
Contributor

eladb commented Jan 23, 2020

Since this is a breaking change it will require a feature flag.

@eladb eladb added the good first issue Related to contributions. See CONTRIBUTING.md label Jan 23, 2020
@eladb
Copy link
Contributor

eladb commented May 11, 2020

Resolved in #7736

@eladb eladb closed this as completed May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@briancoit @eladb @SomayaB