Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape hatches for modifying resource does not work in python #3431

Closed
1 of 5 tasks
lkoniecz opened this issue Jul 25, 2019 · 1 comment
Closed
1 of 5 tasks

Escape hatches for modifying resource does not work in python #3431

lkoniecz opened this issue Jul 25, 2019 · 1 comment
Assignees
Labels
bug This issue is a bug. language/python Related to Python bindings needs-reproduction This issue needs reproduction. p1 package/cfn Related to the CFN layer (L1)

Comments

@lkoniecz
Copy link

Note: for support questions, please first reference our documentation, then use Stackoverflow. This repository's issues are intended for feature requests and bug reports.

  • I'm submitting a ...

    • 🪲 bug report
    • 🚀 feature request
    • 📚 construct library gap
    • ☎️ security issue or vulnerability => Please see policy
    • ❓ support request => Please see note at the top of this template.
  • What is the current behavior?
    If the current behavior is a 🪲bug🪲: Please provide the steps to reproduce
    According to https://docs.aws.amazon.com/cdk/latest/guide/cfn_layer.html paragraph 'Modifying the AWS CloudFormation Resource behind AWS Constructs'

        loadbalancer = aws_elasticloadbalancing.LoadBalancer(
            # params ommited
        )

        cfn_loadbalancer = loadbalancer.node.default_child
        cfn_loadbalancer.load_balancer_name = 'test'

this should change load balancer name to the value provided, but it does not do anything.

  • What is the expected behavior (or behavior of feature suggested)?

load balancer name changes to test

  • What is the motivation / use case for changing the behavior or adding this feature?

Fill missing constructs functionality.

  • Please tell us about your environment:

    • CDK CLI Version: 1.0.0
    • Module Version: 1.0.0
    • OS: [all ]
    • Language: [Python ]
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. associated pull-request, stackoverflow, gitter, etc)

@lkoniecz lkoniecz added the needs-triage This issue or PR still needs to be triaged. label Jul 25, 2019
@eladb eladb added the package/cfn Related to the CFN layer (L1) label Aug 13, 2019
@eladb eladb self-assigned this Aug 13, 2019
@eladb eladb added bug This issue is a bug. language/python Related to Python bindings labels Aug 13, 2019
@eladb eladb assigned RomainMuller and unassigned eladb Aug 29, 2019
@SomayaB SomayaB added the needs-reproduction This issue needs reproduction. label Sep 11, 2019
@NGL321 NGL321 removed the needs-triage This issue or PR still needs to be triaged. label Oct 5, 2019
@RomainMuller RomainMuller added the p1 label Nov 5, 2019
@RomainMuller
Copy link
Contributor

I have confirmed this works with the current version of CDK (>= 1.18.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. language/python Related to Python bindings needs-reproduction This issue needs reproduction. p1 package/cfn Related to the CFN layer (L1)
Projects
None yet
Development

No branches or pull requests

5 participants