-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(logs): add parameter to allow metric filter on transformed logs #35359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logs): add parameter to allow metric filter on transformed logs #35359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
|
Exemption Request This PR does not change the existing behavior of the class; it only adds a parameter in MetricFilter, when the parameter exists in CfnMetricFilter. |
It changes the This is also not really a |
iankhou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment on the PR.
…r-on-transformed-logs
|
Thanks for your comment. I will add the tests. |
…r-on-transformed-logs
…ameter in MetricFilter of aws-logs
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
I guess the 'exemption-request' label can be removed. |
…r-on-transformed-logs
Pull request has been modified.
…r-on-transformed-logs
…r-on-transformed-logs
…r-on-transformed-logs
…r-on-transformed-logs
…r-on-transformed-logs
…r-on-transformed-logs
…r-on-transformed-logs
iankhou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. This got lost as you did not re-request review, but looks good after adding the tests.
…r-on-transformed-logs
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Not related to any issue.
Reason for this change
It was not possible to pass the argument 'applyOnTransformedLogs' to the class MetricFilter, in order to create MetricFilter, Filter and Alarm.
Description of changes
Since MetricFilter makes use of CfnMetricFilter, which allows the parameter 'applyOnTransformedLogs', this change adds the parameter 'applyOnTransformedLogs' to MetricFilterOptions, which is directly passed to the CfnMetric class.
Describe any new or updated permissions being added
No permission is added or updated.
Description of how you validated changes
I tested by hand.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license