Skip to content

Conversation

@kg-aws
Copy link
Contributor

@kg-aws kg-aws commented Oct 6, 2025

Issue # (if applicable)

Closes #35644

Reason for this change

Fix the Task Definition validations for Managed Instances based off the public documentation

Public Doc: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definition_parameters-managed-instances.html#constraints-managed-instances

Description of changes

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Add unit tests for the validations

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 6, 2025 19:48
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Oct 6, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@aemada-aws aemada-aws self-assigned this Oct 8, 2025
@aemada-aws aemada-aws added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Oct 10, 2025
@aemada-aws aemada-aws dismissed aws-cdk-automation’s stale review October 10, 2025 14:20

Unit tests are enough as all changes are synth time validations

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 10, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot removed the queued label Oct 10, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 10, 2025
@mergify mergify bot merged commit 8638a78 into aws:main Oct 10, 2025
19 of 20 checks passed
@mergify mergify bot removed the queued label Oct 10, 2025
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2025
@kg-aws kg-aws deleted the fix_ecs_task_def branch November 3, 2025 15:25
@kg-aws kg-aws restored the fix_ecs_task_def branch November 3, 2025 15:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ecs: Managed Instances capacity providers, task definitions, and services

3 participants