Skip to content

Conversation

@aemada-aws
Copy link
Contributor

@aemada-aws aemada-aws commented Oct 15, 2025

Issue # (if applicable)

Call out from #35742

ManagedInstancesCapacityProvider should implement IConnectable to make managing the SGs for the provider easier. This was missed in the initial PR.

Reason for this change

Implement IConnectable for ManagedInstancesCapacityProvider. ManagedInstancesCapacityProvider makes use of EC2 security groups, so it should implement this interface.

Description of changes

Implement IConnectable for ManagedInstancesCapacityProvider

Describe any new or updated permissions being added

None

Description of how you validated changes

Modified and deployed integ test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 15, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team October 15, 2025 09:38
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 15, 2025
@aemada-aws aemada-aws marked this pull request as draft October 15, 2025 09:58
@aemada-aws aemada-aws force-pushed the iconn-managed-provider-ecs branch from 17811c7 to a615031 Compare October 15, 2025 12:46
@aemada-aws aemada-aws marked this pull request as ready for review October 15, 2025 12:46
@aemada-aws aemada-aws force-pushed the iconn-managed-provider-ecs branch 2 times, most recently from 892b788 to 6b36fbc Compare October 15, 2025 12:50
@aemada-aws aemada-aws force-pushed the iconn-managed-provider-ecs branch from 6b36fbc to 1fc57ac Compare October 15, 2025 12:50
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 20, 2025
@ozelalisen ozelalisen self-assigned this Oct 21, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 21, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot added dequeued and removed queued labels Oct 21, 2025
@mergify mergify bot removed the dequeued label Oct 21, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 21, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 21, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit fd5ff76 into aws:main Oct 21, 2025
19 of 20 checks passed
@mergify mergify bot removed the queued label Oct 21, 2025
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants