-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(ecs): implement IConnectable interface for ManagedInstancesCapacityProvider #35745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
17811c7 to
a615031
Compare
892b788 to
6b36fbc
Compare
6b36fbc to
1fc57ac
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Call out from #35742
ManagedInstancesCapacityProvider should implement IConnectable to make managing the SGs for the provider easier. This was missed in the initial PR.
Reason for this change
Implement IConnectable for ManagedInstancesCapacityProvider. ManagedInstancesCapacityProvider makes use of EC2 security groups, so it should implement this interface.
Description of changes
Implement IConnectable for ManagedInstancesCapacityProvider
Describe any new or updated permissions being added
None
Description of how you validated changes
Modified and deployed integ test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license