Skip to content

Conversation

@kumvprat
Copy link
Contributor

@kumvprat kumvprat commented Oct 16, 2025

Reason for this change

For #34635, moving the fallback of latest lambda node runtime to node 22.x

Description of changes

Changed fallback in determineLatestNodeRuntime to Nodejs 22.x for users that use AWS account in regions which don't have aregional fact present

Description of how you validated changes

Ran all unit and integration tests to check that the change is valid

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…to node 22 in regions where LATEST_NODE_RUNTIME is not a fact
@github-actions github-actions bot added the p2 label Oct 16, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team October 16, 2025 16:32
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 16, 2025
@kumvprat kumvprat changed the title chore: Change the determineLatestNodeRuntime method call to fallback to node 22 in regions where LATEST_NODE_RUNTIME is not a fact fix(lambda-runtime): change fallback for latest lambda node runtime to node 22.x Oct 16, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@kumvprat
Copy link
Contributor Author

Exemption requested as the change won't affect any tests

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Oct 16, 2025
@kumvprat kumvprat requested a review from a team as a code owner October 17, 2025 15:37
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 17, 2025 15:39

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@kumvprat kumvprat removed the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Oct 21, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 21, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 22, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot added queued and removed dequeued labels Oct 22, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #35764 has been dequeued. Mergify failed to merge the pull request. GitHub can't merge the pull request after 14 retries.
Waiting for the branch protection required status checks to be validated.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot added dequeued and removed queued labels Oct 22, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@alvazjor
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2025

refresh

✅ Pull request refreshed

@mergify mergify bot added queued and removed dequeued labels Oct 22, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot added dequeued and removed queued labels Oct 22, 2025
@kumvprat
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2025

refresh

✅ Pull request refreshed

@kumvprat
Copy link
Contributor Author

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added queued and removed dequeued labels Oct 22, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 10fcb1b into main Oct 22, 2025
19 of 20 checks passed
@mergify mergify bot deleted the custom_resource_fallback_runtime branch October 22, 2025 14:07
@mergify mergify bot removed the queued label Oct 22, 2025
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants