-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(lambda-runtime): change fallback for latest lambda node runtime to node 22.x #35764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to node 22 in regions where LATEST_NODE_RUNTIME is not a fact
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
|
|
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
...dejs/test/integ.nodejs.build.images.js.snapshot/cdk-integ-lambda-nodejs-latest.template.json
Show resolved
Hide resolved
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
|
This pull request has been removed from the queue for the following reason: Pull request #35764 has been dequeued. Mergify failed to merge the pull request. GitHub can't merge the pull request after 14 retries. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks:You may have to fix your CI before adding the pull request to the queue again. |
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
For #34635, moving the fallback of latest lambda node runtime to node 22.x
Description of changes
Changed fallback in
determineLatestNodeRuntimeto Nodejs 22.x for users that use AWS account in regions which don't have aregional fact presentDescription of how you validated changes
Ran all unit and integration tests to check that the change is valid
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license