Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(events-targets): allow specifying event for codebuild project target #3637

Merged
merged 9 commits into from
Aug 15, 2019

Conversation

hupe1980
Copy link
Contributor

Add event prop to customize the payload for the StartBuild API:

https://docs.aws.amazon.com/codebuild/latest/APIReference/API_StartBuild.html

Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@eladb eladb self-assigned this Aug 13, 2019
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test and update PR description to match guidelines in contribution guide.

@eladb eladb changed the title feat(events-targets): Add event prop feat(events-targets): allow specifying event for CodeBuildProject target Aug 14, 2019
@hupe1980 hupe1980 changed the title feat(events-targets): allow specifying event for CodeBuildProject target feat(events-targets): allow specifying event for codebuild project target Aug 14, 2019
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment about modifying existing tests

@mergify mergify bot merged commit c240e1e into aws:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants