Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecs-patterns: Enable load balancer subnet configuration in load balanced constructs #3691

Closed
2 tasks
sonofachamp opened this issue Aug 16, 2019 · 2 comments
Closed
2 tasks
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container @aws-cdk/aws-ecs-patterns Related to ecs-patterns library feature-request A feature should be added or improved.

Comments

@sonofachamp
Copy link

🚀 Feature Request

General Information

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

Description

Enable consumers of load balanced constructs in ecs-patterns library to specify which VPC subnets to associate to their load balancer.

Proposed Solution

Expose load balancer properties via the load balancer properties interface.

Environment

  • CDK CLI Version: 1.3.0 (build bba9914)
  • Module Version: ecs-patterns 1.4.0
  • OS: all
  • Language: all

Other information

#3626

@sonofachamp sonofachamp added feature-request A feature should be added or improved. @aws-cdk/aws-ecs Related to Amazon Elastic Container labels Aug 16, 2019
@SoManyHs SoManyHs added the @aws-cdk/aws-ecs-patterns Related to ecs-patterns library label Aug 19, 2019
@bgdnlp
Copy link

bgdnlp commented Aug 21, 2019

As an easier solution, a parameter that takes a load balancer arn or object as input would allow both using an existing load balancer defined somewhere else (#3737) and simply creating a load balancer with the desired properties just before calling LoadBalancedFargateService() or LoadBalancedEc2Service().

@piradeepk
Copy link
Contributor

Closing this feature request in favour of #3737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container @aws-cdk/aws-ecs-patterns Related to ecs-patterns library feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

4 participants