Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bucket.grantRead/Arn.format might be able to emit more efficient statements #375

Closed
eladb opened this issue Jul 18, 2018 · 4 comments
Closed

Comments

@eladb
Copy link
Contributor

eladb commented Jul 18, 2018

Here's an example of an output emitted by bucket.grantRead:

{
    "Fn::Join": [
        "",
        [
            "arn",
            ":",
            { "Ref": "AWS::Partition" },
            ":",
            "s3",
            ":",
            "",
            ":",
            "",
            ":",
            { "Ref": "SampleAssetS3BucketE6B2908E" }
        ]
    ]
}                  
@eladb eladb mentioned this issue Jul 18, 2018
@rix0rrr
Copy link
Contributor

rix0rrr commented Jul 18, 2018

Well that is just silly Why is that not an { "Fn::GetAtt": [ "SampleAssetS3BucketE6B2908E", "Arn" ]}?

And also, do we really care?

@RomainMuller
Copy link
Contributor

It makes the template artificially bigger... Which can become annoying for large applications.

@eladb
Copy link
Contributor Author

eladb commented Jul 18, 2018

It's a kind of aesthetic optimization which we can do if we want, but it's not super important.

@eladb
Copy link
Contributor Author

eladb commented Dec 17, 2018

Closing for now, I believe we are doing some more optimizations now and the outputs are require nice

@eladb eladb closed this as completed Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants