Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eks): retrieve ami with ssm #4156

Merged
merged 12 commits into from
Sep 23, 2019
Merged

feat(eks): retrieve ami with ssm #4156

merged 12 commits into from
Sep 23, 2019

Conversation

nmussy
Copy link
Contributor

@nmussy nmussy commented Sep 19, 2019 •
edited
Loading

  • add EksOptimizedImage
  • move ami.ts into cluster.ts

BREAKING CHANGES:

  • Remove EksOptimizedAmi, replaced with EksOptimizedImage.
  • Rename EksOptimizedAmiProps -> EksOptimizedImageProps
  • Rename NodeType.NORMAL -> NodeType.STANDARD

Fixes #4152

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@nmussy nmussy requested a review from eladb as a code owner September 19, 2019 08:36
@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@nmussy
Copy link
Contributor Author

nmussy commented Sep 19, 2019 •
edited
Loading

I'm not sure why I got such a huge diff with the package-lock.json when I added the @aws-cdk/aws-ssm dependency, seems a little fishy

@nmussy nmussy mentioned this pull request Sep 19, 2019
Merged
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb reviewed Sep 20, 2019
View reviewed changes
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb previously approved these changes Sep 22, 2019
View reviewed changes
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot dismissed eladb’s stale review September 23, 2019 07:11

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 622a4e1 into aws:master Sep 23, 2019
@nmussy nmussy deleted the 4152 branch September 23, 2019 12:40
eladb pushed a commit that referenced this pull request Sep 23, 2019
feat(eks): retrieve ami with ssm (#4156)
7e967ab 
* feat(eks): retrieve ami with ssm

* package-lock changes

* chore: remove deprecated, delete ami.ts, move into cluster

* chore: refactor EksOptimizedAmiProps -> EksOptimizedImageProps

* chore: add missing - to JSDoc

* chore: rename NodeType.NORMAL -> STANDARD

* remove note about environment-agnostic stacks in README

* chore: revert package-lock
@stefanolczak stefanolczak mentioned this pull request Apr 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@eladb eladb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[aws-eks] Getting EKS AMI from SSM Paramater Store
3 participants
@nmussy @aws-cdk-automation @eladb