-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECS needs AppMesh proxy configuration support #4162
Comments
@gary-cowell afaik in CDK 1.8.0 (Python) AppMesh is not fully integrated. |
You're right, this requires more feature support on ECS' end. Tagging in @pkandasamy91. In the mean time, I'm not sure what you mean by "I cannot see how I can leverage this technique using the Python CDK which appears not to support the same type of override". The TypeScript code you linked should translate over to Python according to the language translation rules. Something like the following should work: cfn_def = task_definition.node.find_child('Resource')
cfn_def.add_property_override('ProxyConfiguration', {
'Type': 'APPMESH',
'ContainerName': 'envoy',
'ProxyConfigurationProperties': [
{
'Name': 'IgnoredUID',
'Value': '1337',
},
{
'Name': 'ProxyIngressPort',
'Value': '15000',
},
{
'Name': 'ProxyEgressPort',
'Value': '15001',
},
{
'Name': 'AppPorts',
'Value': [YOUR-APP-PORTS],
},
{
'Name': 'EgressIgnoredIPs',
'Value': '169.254.170.2,169.254.169.254',
},
],
}); Does it not? And if it doesn't, can you please be more specific about the errors or behavior you're seeing? |
Yes sorry , I was [and still am a bit] getting bogged down in the typescript->Python language translation and missed how to leverage the add_property_override. This did in fact solve my problem in the short term of being able to enable ProxyConfiguration on my task definitions, pending a cleaner way. Thank you. |
@rix0rrr (and @gary-cowell fyi) the override above will accept just a single app port. |
@gary-cowell proxyConfiguration support should now be available in the CDK: https://github.com/aws/aws-cdk/pull/4007/files. Please let us know if this does not solve your issue. |
Closing this issue. Please reopen if PR: #4007 does not solve your issue. |
❓ How do I configure AppMesh Proxy Configuration using Python CDK for ECS
The Question
Referencing this issue:
#2297 ((AppMesh): Create L2 Construct for AWS AppMesh)
I can see it uses a property override to configure the envoy proxy
I cannot see how I can leverage this technique using the Python CDK which appears not to support the same type of override, and I cannot find Python documentation on this matter.
I have tried the add_override method of CfnCustomResource, but this does not appear to be the same thing.
So, pending an expansion of the CDK to allow L1 access to the Proxy settings in a task definition, is it possible to achieve the above workaround in the Python CDK please? If so, how might this be done?
Environment
Other information
The text was updated successfully, but these errors were encountered: