Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(codebuild): validate if a CodePipeline action that is cross-account does not have outputs #4171

Merged
merged 3 commits into from
Oct 3, 2019
Merged

fix(codebuild): validate if a CodePipeline action that is cross-account does not have outputs #4171

merged 3 commits into from
Oct 3, 2019

Conversation

skinny85
Copy link
Contributor

@skinny85 skinny85 commented Sep 20, 2019 •
edited
Loading

CodeBuild does not honor the key set on the project if the key is from a different account. That means a cross-account CodeBuild action effectively cannot have outputs (as they will be written with the default S3 key of the CodeBuild account, which the other actions won't have access to).

Add validation that throws an error if there is an attempt to add a cross-account CodeBuild action with outputs.

Fixes #4032

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@skinny85 skinny85 requested a review from eladb September 20, 2019 00:26
@mergify
Copy link
Contributor

mergify bot commented Sep 20, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@skinny85 skinny85 force-pushed the fix/codebuild-cross-account-pipeline-outputs branch from 358a00a to 93a09af Compare September 20, 2019 00:55
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@skinny85 skinny85 added the pr/do-not-merge This PR should not be merged at this time. label Sep 20, 2019
@skinny85 skinny85 force-pushed the fix/codebuild-cross-account-pipeline-outputs branch from 93a09af to 1f7f76e Compare September 20, 2019 21:47
@skinny85
Copy link
Contributor Author

Rebased on top of 1.9.0.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@skinny85 skinny85 mentioned this pull request Sep 21, 2019
Merged
@skinny85 skinny85 force-pushed the fix/codebuild-cross-account-pipeline-outputs branch from 1f7f76e to 5e2da6d Compare September 24, 2019 18:45
@skinny85
Copy link
Contributor Author

Newest version - rebased + removed validateCrossAccountOutputs.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update your PR description to include the motivation for this change

@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
@skinny85 skinny85 force-pushed the fix/codebuild-cross-account-pipeline-outputs branch from 5e2da6d to 743eb15 Compare October 2, 2019 23:15
@skinny85
Copy link
Contributor Author

skinny85 commented Oct 2, 2019

Rebased.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@skinny85 skinny85 merged commit 1744f8a into aws:master Oct 3, 2019
@skinny85 skinny85 deleted the fix/codebuild-cross-account-pipeline-outputs branch October 3, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@skinny85 skinny85

Labels
contribution/core This is a PR that came from AWS. pr/do-not-merge This PR should not be merged at this time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add validation for a cross-account CodeBuild CodePipeline action with outputs
4 participants
@skinny85 @aws-cdk-automation @eladb @NGL321