fix(ecr-assets): docker build targets #4185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(aws-ecs): add build target for docker image asset, feat(aws-ecs): add build target for docker image asset, feat(cx-api): add build target for docker image asset, feat(aws-cdk): build docker images with target when provided fixes aws#4184
themizzi
requested review from
eladb,
rix0rrr,
RomainMuller and
SoManyHs
as code owners
|
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
changed the title
eladb
changed the title
eladb
changed the title
eladb
approved these changes
Sep 22, 2019
|
Thank you for contributing! Your pull request is now being automatically merged. |
eladb
pushed a commit
that referenced
this pull request
Sep 23, 2019
* feat(aws-ecr-assets): add build target for docker image asset, feat(aws-ecs): add build target for docker image asset, feat(aws-ecs): add build target for docker image asset, feat(cx-api): add build target for docker image asset, feat(aws-cdk): build docker images with target when provided fixes #4184 * fix(aws-cdk): use push instead of concat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to use docker build targets when building docker image assets.
implements #4184
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license