Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecr-assets): give accurate error when Tokens are being used #4255

Merged
merged 2 commits into from
Sep 27, 2019
Merged

fix(ecr-assets): give accurate error when Tokens are being used #4255

merged 2 commits into from
Sep 27, 2019

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Sep 26, 2019

Fixes #3795.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr rix0rrr self-assigned this Sep 26, 2019
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
@rix0rrr rix0rrr added the effort/small Small work item – less than a day of effort label Sep 27, 2019
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2019

Thank you for contributing! Your pull request is now being automatically merged.

RomainMuller
RomainMuller reviewed Sep 27, 2019
View reviewed changes
packages/@aws-cdk/aws-ecr-assets/lib/image-asset.ts
function validateProps(props: DockerImageAssetProps) {
for (const [key, value] of Object.entries(props)) {
if (Token.isUnresolved(value)) {
throw new Error(`Cannot use Token as value of '${key}': this value is used before deployment starts`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be sweet to have some info about what it's used for before deployment starts...

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1381b2d into master Sep 27, 2019
@mergify mergify bot deleted the huijbers/asset-tokens branch September 27, 2019 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainMuller RomainMuller RomainMuller left review comments

@eladb eladb eladb approved these changes

@skinny85 skinny85 Awaiting requested review from skinny85

@nija-at nija-at Awaiting requested review from nija-at

@shivlaks shivlaks Awaiting requested review from shivlaks

Assignees

@rix0rrr rix0rrr

Labels
contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InvalidParameterType error when trying to pass repository_name to DockerImageAsset
5 participants
@rix0rrr @aws-cdk-automation @RomainMuller @eladb @NGL321