Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "enableSpotInstanceDraining Field #4301

Closed
2 tasks
pavneeta opened this issue Sep 30, 2019 · 1 comment · Fixed by #4360
Closed
2 tasks

Add "enableSpotInstanceDraining Field #4301

pavneeta opened this issue Sep 30, 2019 · 1 comment · Fixed by #4360
Assignees
@rix0rrr @piradeepk
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container feature-request A feature should be added or improved.

Comments

@pavneeta
Copy link

pavneeta commented Sep 30, 2019 •
edited
Loading

ECS just launched Automated Spot Instance Draining and It would be great if we could add the enableSpotInstanceDrainingfield in the CDK . See the what's new post here - https://aws.amazon.com/about-aws/whats-new/2019/09/amazon-ecs-supports-automated-draining-for-spot-instances-running-ecs-services/

Use Case

This Tweet explains it well - https://twitter.com/pahudnet/status/1177770120577306624

Proposed Solution

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@pavneeta pavneeta added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 30, 2019
@uttarasridhar uttarasridhar added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Sep 30, 2019
@nmussy
Copy link
Contributor

nmussy commented Oct 1, 2019

It's either dependent or a duplicate of #1711

@rix0rrr rix0rrr removed the needs-triage This issue or PR still needs to be triaged. label Oct 1, 2019
This was referenced Oct 3, 2019
Closed
Merged
@mergify mergify bot closed this as completed in #4360 Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

@piradeepk piradeepk

Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ecs): add automated spot instance draining support
add ECS automated spot draining support
5 participants
@rix0rrr @uttarasridhar @nmussy @piradeepk @pavneeta