Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add tags to CDKToolkit stack through bootstrap cli command #4320

Merged
merged 9 commits into from
Oct 9, 2019
Merged

feat(cli): add tags to CDKToolkit stack through bootstrap cli command #4320

merged 9 commits into from
Oct 9, 2019

Conversation

selvathiruarul
Copy link
Contributor

@selvathiruarul selvathiruarul commented Oct 1, 2019 •
edited by shivlaks
Loading

Tags will also propagate to the S3 bucket created by the bootstrap command

Closes #4227

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Oct 1, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

shivlaks
shivlaks previously requested changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add unit tests for this here.

The PR checklist also points towards CLI integration tests and I think we should make sure we add one as well.

@mergify mergify bot dismissed shivlaks’s stale review October 5, 2019 06:04

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

shivlaks
shivlaks reviewed Oct 7, 2019
View reviewed changes
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shivlaks shivlaks changed the title feat(cli): add tags to bootstrap cli(#4227) feat(cli): add tags to CDKToolkit stack through bootstrap cli command (#4320) Oct 9, 2019
@shivlaks shivlaks changed the title feat(cli): add tags to CDKToolkit stack through bootstrap cli command (#4320) feat(cli): add tags to CDKToolkit stack through bootstrap cli command Oct 9, 2019
shivlaks
shivlaks reviewed Oct 9, 2019
View reviewed changes
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small thing, let's get this thing checked in!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 4284aa2 into aws:master Oct 9, 2019
@benfarr
Copy link

benfarr commented Oct 9, 2019

@selvathiruarul Great feature add and work on this!

shivlaks added a commit that referenced this pull request Oct 15, 2019
@shivlaks
fix(cli) fix bootstrap so that it has a default for tags on the stack.
e338945 
The bootstrap command was enhanced to support tags in #4320
However, the default is undefined which doesn't work when tags are not supplied.

Updated default and the integ test so both scenarios are being tested.

Fixes #4518
@shivlaks shivlaks mentioned this pull request Oct 15, 2019
Merged
shivlaks added a commit that referenced this pull request Oct 15, 2019
@shivlaks
fix(cli): fix bootstrap so that it has a default for tags on the stac…
f4a20a6 
…k. (#4519)

The bootstrap command was enhanced to support tags in #4320
However, the default is undefined which doesn't work when tags are not supplied.

Updated default and the integ test so both scenarios are being tested.

Fixes #4518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivlaks shivlaks shivlaks approved these changes

@RomainMuller RomainMuller Awaiting requested review from RomainMuller

Assignees

@shivlaks shivlaks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag cdk toolkit stack
5 participants
@selvathiruarul @aws-cdk-automation @benfarr @shivlaks @selva-thiruarul