Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration test that ensures that all CDK modules have type information exported correctly #4363

Closed
nija-at opened this issue Oct 3, 2019 · 1 comment
Closed

integration test that ensures that all CDK modules have type information exported correctly #4363

nija-at opened this issue Oct 3, 2019 · 1 comment
Assignees
@RomainMuller
Labels
@aws-cdk/assert Related to the @aws-cdk/assert package package/tools Related to AWS CDK Tools or CLI

Comments

@nija-at
Copy link
Contributor

nija-at commented Oct 3, 2019

We need integration tests that validate that tsc succeeds when importing CDK modules.

Required to prevent releasing customer impacting changes like #4352
@nija-at nija-at added needs-triage This issue or PR still needs to be triaged. package/tools Related to AWS CDK Tools or CLI and removed needs-triage This issue or PR still needs to be triaged. labels Oct 3, 2019
@nija-at nija-at mentioned this issue Oct 3, 2019
Closed
@NGL321 NGL321 added the chore label Oct 3, 2019
@NGL321 NGL321 added the @aws-cdk/assert Related to the @aws-cdk/assert package label Oct 3, 2019
@nija-at
Copy link
Contributor Author

nija-at commented Oct 16, 2019 •
edited
Loading

Added these tests as a pre-release tests as part of our CDK release pipeline.

Resolving.

@nija-at nija-at closed this as completed Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomainMuller RomainMuller

Labels
@aws-cdk/assert Related to the @aws-cdk/assert package package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RomainMuller @NGL321 @nija-at