Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: EventBridge Resources #4455

Closed
3 of 4 tasks
dehli opened this issue Oct 10, 2019 · 7 comments
Closed
3 of 4 tasks

Feature: EventBridge Resources #4455

dehli opened this issue Oct 10, 2019 · 7 comments
Assignees
Labels
@aws-cdk/aws-events Related to CloudWatch Events feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed.

Comments

@dehli
Copy link
Contributor

dehli commented Oct 10, 2019

With the release of event bus in CloudFormation (Announcement) we can create an EventBus resource and also update the Rule resource to optionally have an EventBus passed in.

Use Case

Want to use the new EventBridge resources.

Proposed Solution

Currently working on a solution following other resources as an example.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

Status


This is a 🚀 Feature Request

@dehli dehli added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 10, 2019
@NGL321 NGL321 added package/aws-serverless needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. and removed needs-triage This issue or PR still needs to be triaged. labels Oct 10, 2019
@NGL321 NGL321 assigned NGL321, rix0rrr and nija-at and unassigned NGL321 Oct 10, 2019
@NGL321
Copy link
Contributor

NGL321 commented Oct 10, 2019

Hey @dehli,

Once the Cloudformation Team adds the functionality for EventBridge into their Resource Specification, the CDK should automatically update with a new L1 construct.

Unfortunately, we have no control over when this happens. If you would like more information, I would reach out to the Cloudformation team in their forum. Otherwise, I will update this issue when we have more information on timeline.

😸

@dehli
Copy link
Contributor Author

dehli commented Oct 10, 2019

Thanks @NGL321! I started to build the L2? construct and then realized the specification hadn't been updated to include an AWS::Events::EventBus so I didn't get too far. 😄 Cheers!

@ali-habibzadeh
Copy link

Really looking forward to getting this too 👍

@nija-at nija-at added @aws-cdk/aws-events Related to CloudWatch Events and removed package/aws-serverless labels Oct 21, 2019
@nija-at nija-at removed their assignment Oct 21, 2019
@aripalo
Copy link

aripalo commented Nov 2, 2019

If I understood correctly, it seems that the EventBridge is now in the Resource Specification:
Screenshot 2019-11-02 at 17 24 39

@dehli
Copy link
Contributor Author

dehli commented Nov 3, 2019

Yep! @aripalo An AWS::Events::EventBus L2 construct was merged in here: bbec8c5

Still need to add an eventBusName to the Rule construct and then this issue can be closed.

@dehli
Copy link
Contributor Author

dehli commented Nov 6, 2019

With #4839 being merged in, this has been completed. I'll go ahead and close the issue!

@dehli dehli closed this as completed Nov 6, 2019
@0xdevalias
Copy link
Contributor

0xdevalias commented Mar 31, 2020

Ended up here from Google, it's kind of confusing that all of the doco talks about CloudWatch Events, yet the service is called EventBridge. Did this get rebranded or something? Should the doco be updated to better match the current reality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-events Related to CloudWatch Events feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed.
Projects
None yet
Development

No branches or pull requests

7 participants