Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codepipeline): add ability to override env variables in CodeBuild actions #4502

Merged
merged 1 commit into from
Oct 23, 2019
Merged

feat(codepipeline): add ability to override env variables in CodeBuild actions #4502

merged 1 commit into from
Oct 23, 2019

Conversation

skinny85
Copy link
Contributor

@skinny85 skinny85 commented Oct 15, 2019 •
edited
Loading

Previously, environment variables were always defined on the CodeBuild project level,
which made it difficult to re-use the same project in the pipeline.
Now, you can specify environment variables on the CodeBuild action level,
which will override any project-level settings.

Fixes #4531

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@skinny85 skinny85 requested a review from rix0rrr October 15, 2019 00:04
@mergify
Copy link
Contributor

mergify bot commented Oct 15, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@SomayaB SomayaB added the @aws-cdk/core Related to core CDK functionality label Oct 15, 2019
@SomayaB SomayaB added contribution/core This is a PR that came from AWS. and removed @aws-cdk/core Related to core CDK functionality labels Oct 15, 2019
@skinny85 skinny85 mentioned this pull request Oct 16, 2019
Closed
2 tasks
@skinny85
Copy link
Contributor Author

@rix0rrr ping

@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Oct 23, 2019
@skinny85
feat(codepipeline): add ability to override env variables in CodeBuil…
48f4209 
…d actions

Previously, environment variables were always defined on the CodeBuild project level,
which made it difficult to re-use the same project in the pipeline.
Now, you can specify environment variables on the CodeBuild action level,
which will override any project-level settings.

Fixes aws#4531
@skinny85 skinny85 force-pushed the feat/pipeline-codebuild-env-variables branch from 907f76a to 48f4209 Compare October 23, 2019 19:11
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@skinny85 skinny85 merged commit c0c0513 into aws:master Oct 23, 2019
@skinny85 skinny85 deleted the feat/pipeline-codebuild-env-variables branch October 23, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@skinny85 skinny85

Labels
contribution/core This is a PR that came from AWS. pr/do-not-merge This PR should not be merged at this time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support setting environment variables on aws codebuild jobs from codepipline
4 participants
@skinny85 @aws-cdk-automation @rix0rrr @SomayaB