Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autoscaling.AutoscalingGroup does not implement IGrantable #4554

Closed
1 of 2 tasks
abelmokadem opened this issue Oct 17, 2019 · 2 comments · Fixed by #4654
Closed
1 of 2 tasks

autoscaling.AutoscalingGroup does not implement IGrantable #4554

abelmokadem opened this issue Oct 17, 2019 · 2 comments · Fixed by #4654
Assignees
@rix0rrr
Labels
@aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on.

Comments

@abelmokadem
Copy link
Contributor

I'm missing IGrantable on AutoscalingGroup. The role property is there but the interface IGrantable is not implemented.

Use Case

To make my eks life easier.

Proposed Solution

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@abelmokadem abelmokadem added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 17, 2019
@SomayaB SomayaB added the @aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling label Oct 17, 2019
@rix0rrr
Copy link
Contributor

rix0rrr commented Oct 21, 2019

You are right. It should be an easy change, do you feel okay adding it?

@rix0rrr rix0rrr added good first issue Related to contributions. See CONTRIBUTING.md and removed needs-triage This issue or PR still needs to be triaged. labels Oct 21, 2019
@abelmokadem
Copy link
Contributor Author

Yes yes, I actually have a list of issues I want to work through, but I will do this one today. Please hold me accountable 😬

@abelmokadem abelmokadem mentioned this issue Oct 23, 2019
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Oct 23, 2019
@mergify mergify bot closed this as completed in #4654 Oct 24, 2019
@jk21 jk21 mentioned this issue Nov 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(autoscaling): let AutoScalingGroup be IGrantable
3 participants
@rix0rrr @abelmokadem @SomayaB