Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(elbv2): support redirect actions on ALBs #4606

Merged
merged 2 commits into from
Oct 29, 2019
Merged

feat(elbv2): support redirect actions on ALBs #4606

merged 2 commits into from
Oct 29, 2019

Conversation

zxkane
Copy link
Contributor

@zxkane zxkane commented Oct 21, 2019

Close #4546.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@zxkane zxkane requested a review from rix0rrr as a code owner October 21, 2019 14:49
@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@zxkane zxkane force-pushed the feat-alb-redirect-action branch from 1470cb1 to faaf1c1 Compare October 23, 2019 16:23
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@zxkane zxkane force-pushed the feat-alb-redirect-action branch from faaf1c1 to 4ba23c0 Compare October 24, 2019 01:18
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@zxkane zxkane force-pushed the feat-alb-redirect-action branch from 4ba23c0 to 47f0be1 Compare October 24, 2019 02:08
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@rix0rrr rix0rrr changed the title feat(elbv2): add redirect action of ALB's listener feat(elbv2): support redirect actions on ALBs Oct 29, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c770d3c into aws:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support redirect action of ALB listener
3 participants
@zxkane @aws-cdk-automation @rix0rrr