Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecs): add support for start and stop timeout in ContainerDefinition #4638

Merged
merged 3 commits into from
Oct 23, 2019
Merged

feat(ecs): add support for start and stop timeout in ContainerDefinition #4638

merged 3 commits into from
Oct 23, 2019

Conversation

iamhopaul123
Copy link
Contributor

@iamhopaul123 iamhopaul123 commented Oct 22, 2019 •
edited by piradeepk
Loading

Add startTimeout and stopTimeout properties to ContainerDefinition to define per-container dependency start and stop timeout value.

Fix #4410.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@iamhopaul123 iamhopaul123 removed the request for review from rix0rrr October 22, 2019 21:24
@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@SomayaB SomayaB added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Oct 22, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@iamhopaul123 iamhopaul123 changed the title feature(ecs): add start|stop timeout for ContainerDefinition feat(ecs): add start|stop timeout for ContainerDefinition Oct 23, 2019
@piradeepk piradeepk changed the title feat(ecs): add start|stop timeout for ContainerDefinition feat(ecs): support start timeout and stop timeout in ContainerDefinition Oct 23, 2019
@piradeepk piradeepk changed the title feat(ecs): support start timeout and stop timeout in ContainerDefinition feat(ecs): add support for start timeout and stop timeout in ContainerDefinition Oct 23, 2019
@piradeepk piradeepk changed the title feat(ecs): add support for start timeout and stop timeout in ContainerDefinition feat(ecs): add support for start and stop timeout in ContainerDefinition Oct 23, 2019
piradeepk
piradeepk previously requested changes Oct 23, 2019
View reviewed changes
packages/@aws-cdk/aws-ecs/lib/container-definition.ts Outdated
*
* @default - No start timeout.
*/
readonly startTimeOut?: cdk.Duration;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Timeout is one word, startTimeout

packages/@aws-cdk/aws-ecs/lib/container-definition.ts Outdated
*
* @default - No stop timeout.
*/
readonly stopTimeOut?: cdk.Duration;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Timeout is one word, stopTimeout

packages/@aws-cdk/aws-ecs/lib/container-definition.ts Outdated
readonly startTimeOut?: cdk.Duration;

/**
* Time duration to wait before the container is forcefully killed if it doesn't exit normally on its own.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above.

@iamhopaul123 iamhopaul123 force-pushed the add-start-stop-timeout branch from 0d74df7 to b5a1b22 Compare October 23, 2019 17:26
@mergify mergify bot dismissed piradeepk’s stale review October 23, 2019 17:26

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@iamhopaul123 iamhopaul123 force-pushed the add-start-stop-timeout branch from 722f397 to 8a28b02 Compare October 23, 2019 18:13
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

piradeepk
piradeepk approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b00c0af into aws:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piradeepk piradeepk piradeepk approved these changes

@SoManyHs SoManyHs Awaiting requested review from SoManyHs

Assignees

@piradeepk piradeepk

Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-ecs - (start|stop)Timeout for ContainerDefinitionOptions
5 participants
@iamhopaul123 @aws-cdk-automation @piradeepk @SomayaB @SoManyHs