Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(cli): always exit with 0 on cdk diff (#4650)" #4708

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Revert "fix(cli): always exit with 0 on cdk diff (#4650)" #4708

merged 1 commit into from
Oct 28, 2019

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Oct 28, 2019

This change includes a breaking change in our stable APIs.
We will have to discuss this furthre in order to make a decision
to actually break.

This reverts commit 4f765b2.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Revert "fix(cli): always exit with 0 on cdk diff (#4650)"
7463f14 
This change includes a breaking change in our stable APIs.
We will have to discuss this furthre in order to make a decision
to actually break.

This reverts commit 4f765b2.
@eladb eladb requested a review from RomainMuller as a code owner October 28, 2019 09:36
@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@eladb
Copy link
Contributor Author

eladb commented Oct 28, 2019

@jogold we decided to revert this change in order to discuss the correct strategy since it is a breaking change in our stable CLI API.

@eladb eladb merged commit 7d8a68a into master Oct 28, 2019
@eladb eladb deleted the benisrae/revert-diff-fails-2 branch October 28, 2019 09:40
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@hoegertn
Copy link
Contributor

@eladb can you then implement a --no-fail on cdk diff to mimic this feature?

@eladb
Copy link
Contributor Author

eladb commented Oct 28, 2019

That's exactly what we want to do

jogold added a commit to jogold/aws-cdk that referenced this pull request Oct 28, 2019
@jogold
feat(cli): add --no-fail option to diff
62dc470 
Use `cdk diff --no-fail` to exit with 0 even when there is a diff.

To avoid a CLI breaking change, the default remains to fail on diff.

Related to aws#4650 and aws#4708
@jogold jogold mentioned this pull request Oct 28, 2019
Merged
@SomayaB SomayaB added the contribution/core This is a PR that came from AWS. label Nov 14, 2019
mergify bot pushed a commit that referenced this pull request Nov 28, 2019
@jogold @mergify
feat(cli): always exit with 0 on cdk diff (under feature flag) (#4721)
3ffd810 
* feat(cli): add --no-fail option to diff

Use `cdk diff --no-fail` to exit with 0 even when there is a diff.

To avoid a CLI breaking change, the default remains to fail on diff.

Related to #4650 and #4708

* use feature flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eladb @aws-cdk-automation @hoegertn @RomainMuller @SomayaB