-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): cdk init --generate-only #4826
Conversation
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like it’s taking things a bit too far. We are very careful to add complexity around init templates because the abuse potential is high. My understanding is that given package.json yarn can very easily create a lock file. Do we really need this to be part of the template?
Maybe we can just add to the template a readme instruction on how to use yarn?
@eladb The issue isn't with using the Another solution might be a |
|
init --generate-only
CLI option
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
I realized when testing aws-cdk/packages/aws-cdk/lib/settings.ts Line 236 in d044461
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request is now being automatically merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
init --generate-only
CLI option
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Starting with a draft to get the ball rolling.
I'm not pleased with the
yarn
detection, maybe we should just stick with--package-manager
?Fixes #4795
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license