Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apigateway): allow multiple api keys to the same usage plan #4903

Merged
merged 4 commits into from
Nov 8, 2019
Merged

fix(apigateway): allow multiple api keys to the same usage plan #4903

merged 4 commits into from
Nov 8, 2019

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Nov 7, 2019

fixes #4860

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@nija-at nija-at requested a review from a team November 7, 2019 16:29
@nija-at nija-at requested a review from eladb as a code owner November 7, 2019 16:29
@nija-at nija-at self-assigned this Nov 7, 2019
@mergify
Copy link
Contributor

mergify bot commented Nov 7, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@nija-at nija-at mentioned this pull request Nov 7, 2019
Closed
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb eladb added the pr/do-not-merge This PR should not be merged at this time. label Nov 8, 2019
eladb
eladb approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with a few minor fixes (remove do-not-merge label when you are ready)

packages/@aws-cdk/aws-apigateway/lib/usage-plan.ts Outdated Show resolved Hide resolved
@nija-at nija-at requested a review from eladb November 8, 2019 13:54
@nija-at nija-at removed the pr/do-not-merge This PR should not be merged at this time. label Nov 8, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit 142bd0e into master Nov 8, 2019
@mergify mergify bot deleted the nija-at/multiple-apikeys-usageplan branch November 8, 2019 15:19
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@SomayaB SomayaB added the contribution/core This is a PR that came from AWS. label Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb Awaiting requested review from eladb

Assignees

@nija-at nija-at

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[apigateway] Cannot call UsagePlan.addApiKey multiple times.
4 participants
@nija-at @aws-cdk-automation @eladb @SomayaB