-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(custom-resources): allow specifying role for AwsCustomResource #4909
Conversation
Also removed console.log outputs from tests Closes aws#4906
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
@@ -132,6 +132,15 @@ export interface AwsCustomResourceProps { | |||
*/ | |||
readonly policyStatements?: iam.PolicyStatement[]; | |||
|
|||
/** | |||
* The execution role for the Lambda function implementing this custom | |||
* resource. The role must be assumable by the `lambda.amazonaws.com` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function is implementing the "custom resource provider". It's an important distinction because it's a singleton, so the role will apply to all AwsCustomResource
instances in your app. Probably fine, but worth documenting.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request is now being automatically merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Also removed useless console.log outputs from tests
Closes #4906
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license