Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): support aws-node-termination-handler as the default spot draining handler #4931

Merged
merged 2 commits into from
Nov 10, 2019
Merged

feat(eks): support aws-node-termination-handler as the default spot draining handler #4931

merged 2 commits into from
Nov 10, 2019

Conversation

pahud
Copy link
Contributor

@pahud pahud commented Nov 8, 2019

feat(aws-eks): support aws/aws-node-termination-handler as the default spot draining handler(fix #4913 )


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@pahud pahud requested a review from eladb as a code owner November 8, 2019 16:27
@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb eladb changed the title feat(aws-eks): support aws/aws-node-termination-handler as the default spot draining handler feat(eks): support aws-node-termination-handler as the default spot draining handler Nov 10, 2019
@mergify
Copy link
Contributor

mergify bot commented Nov 10, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f4a41d1 into aws:master Nov 10, 2019
@mrsiejas
Copy link
Contributor

mrsiejas commented Aug 25, 2021

@pahud @eladb Wondering how(if?) this is going to work with one of the Best practice recommendations which is Restricting access to the IMDS and Amazon EC2 instance profile credentials? If not, perhaps its a good idea to add it via new ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-eks] aws-eks to support aws/aws-node-termination-handler as the official spot draining handler
4 participants