feat(amplify): App, Branch and Domain #5177

jogold · 2019-11-25T13:17:32Z

Add L2 constructs for AWS Amplify Console: App, Branch and Domain.

Apps and branches can be password protected with a Secrets Manager generated password.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Add L2 constructs for AWS Amplify Console: App, Branch and Domain. Apps and branches can be password protected with a Secrets Manager generated password.

mergify · 2019-11-25T13:18:38Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

aws-cdk-automation · 2019-11-25T13:47:14Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-11T09:17:21Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-12T10:33:42Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-12T10:34:46Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2019-12-16T12:33:47Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

mergify · 2019-12-16T13:00:59Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

mergify · 2019-12-16T13:53:16Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

mergify · 2019-12-16T14:38:57Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

mergify · 2019-12-16T14:52:39Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

mergify · 2019-12-16T15:17:45Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

aws-cdk-automation · 2019-12-19T22:11:57Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-30T10:52:51Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-08T09:23:13Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-16T14:26:04Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-18T11:01:15Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-24T09:46:09Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jogold · 2020-02-11T15:24:31Z

@shivlaks @MrArnoldPalmer any update here? anything I can do to help?

MrArnoldPalmer · 2020-02-11T18:03:52Z

@shivlaks and I have been talking about this and playing with it a bit. Overall It feels pretty good but we both want to familiarize ourselves with the service overall a bit more. We just recently started this so expect some feedback sometime this week.

jogold · 2020-02-11T19:39:11Z

Got it, thanks for the feedback.

MrArnoldPalmer · 2020-02-19T20:35:03Z

packages/@aws-cdk/aws-amplify/lib/app.ts

+   *
+   * @default - not connected to a repository
+   */
+  readonly repository?: string;


The repository and oauthToken params support all the various git providers right? Not just github?

Not tested but yes it should be the case.

Q: What Git source code providers does AWS Amplify Console support?
You can connect private and public repositories from GitHub, BitBucket, GitLab, and AWS CodeCommit.

https://aws.amazon.com/amplify/console/faqs/

aws-cdk-automation · 2020-02-26T11:10:38Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 93ce1c1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-02-26T14:57:28Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: d0bdc63
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

MrArnoldPalmer

This feels like a pretty good start. I think there are some possibilities for us to abstract some of the repo config into higher level interfaces, but I think we should start with staying relatively close to CFN api and start getting feedback.

Thanks @jogold 🔥🔥🔥

mergify · 2020-03-03T17:50:01Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

aws-cdk-automation · 2020-03-03T20:31:58Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 90578d8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2020-03-03T20:32:22Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

* feat(amplify): add L2 constructs Add L2 constructs for AWS Amplify Console: App, Branch and Domain. Apps and branches can be password protected with a Secrets Manager generated password. * README and JSDoc * delete empty test file * import style

feat(amplify): add L2 constructs

a5bf69a

Add L2 constructs for AWS Amplify Console: App, Branch and Domain. Apps and branches can be password protected with a Secrets Manager generated password.

jogold requested a review from shivlaks as a code owner November 25, 2019 13:17

SomayaB assigned shivlaks Nov 25, 2019

jogold changed the title ~~feat(amplify): add L2 constructs~~ feat(amplify): App, Branch and Domain Nov 27, 2019

Merge branch 'master' into amplify-l2

03b86fe

jogold added 2 commits December 12, 2019 11:09

README and JSDoc

aba7f8f

Merge branch 'master' into amplify-l2

aab7539

jogold added 3 commits December 19, 2019 22:21

Merge branch 'master' into amplify-l2

8850f58

delete empty test file

b78b8a5

import style

20c5ba1

Merge branch 'master' into amplify-l2

ff95660

Merge branch 'master' into amplify-l2

c86431d

Merge branch 'master' into amplify-l2

b68bf02

Merge branch 'master' into amplify-l2

61940fb

shivlaks requested a review from MrArnoldPalmer January 22, 2020 08:49

Merge branch 'master' into amplify-l2

0912e6f

Merge branch 'master' into amplify-l2

cdb38ec

MrArnoldPalmer reviewed Feb 25, 2020

View reviewed changes

Merge branch 'master' into amplify-l2

93ce1c1

Merge branch 'master' into amplify-l2

d0bdc63

MrArnoldPalmer previously approved these changes Mar 3, 2020

View reviewed changes

Merge branch 'master' into amplify-l2

90578d8

jogold requested a review from MrArnoldPalmer March 3, 2020 20:08

MrArnoldPalmer approved these changes Mar 3, 2020

View reviewed changes

mergify bot merged commit e126048 into aws:master Mar 3, 2020

jogold deleted the amplify-l2 branch March 3, 2020 20:37

snyk-bot mentioned this pull request Apr 10, 2020

[Snyk] Upgrade aws-cdk from 1.28.0 to 1.30.0 ammobinDOTca/ammobin-cdk#2

Closed

MrArnoldPalmer mentioned this pull request Aug 17, 2020

AWS Amplify Console - Add L2 Construct #3207

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(amplify): App, Branch and Domain #5177

feat(amplify): App, Branch and Domain #5177

jogold commented Nov 25, 2019

mergify bot commented Nov 25, 2019

aws-cdk-automation commented Nov 25, 2019

aws-cdk-automation commented Dec 11, 2019

aws-cdk-automation commented Dec 12, 2019

aws-cdk-automation commented Dec 12, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

aws-cdk-automation commented Dec 19, 2019

aws-cdk-automation commented Dec 30, 2019

aws-cdk-automation commented Jan 8, 2020

aws-cdk-automation commented Jan 16, 2020

aws-cdk-automation commented Jan 18, 2020

aws-cdk-automation commented Jan 24, 2020

jogold commented Feb 11, 2020

MrArnoldPalmer commented Feb 11, 2020

jogold commented Feb 11, 2020

MrArnoldPalmer Feb 19, 2020

jogold Feb 25, 2020

aws-cdk-automation commented Feb 26, 2020

aws-cdk-automation commented Feb 26, 2020

MrArnoldPalmer left a comment

mergify bot commented Mar 3, 2020

aws-cdk-automation commented Mar 3, 2020

mergify bot commented Mar 3, 2020

feat(amplify): App, Branch and Domain #5177

feat(amplify): App, Branch and Domain #5177

Conversation

jogold commented Nov 25, 2019

mergify bot commented Nov 25, 2019

aws-cdk-automation commented Nov 25, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 11, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 12, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 12, 2019

AWS CodeBuild CI Report

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

aws-cdk-automation commented Dec 19, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 30, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 8, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 16, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 18, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 24, 2020

AWS CodeBuild CI Report

jogold commented Feb 11, 2020

MrArnoldPalmer commented Feb 11, 2020

jogold commented Feb 11, 2020

MrArnoldPalmer Feb 19, 2020

Choose a reason for hiding this comment

jogold Feb 25, 2020

Choose a reason for hiding this comment

aws-cdk-automation commented Feb 26, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Feb 26, 2020

AWS CodeBuild CI Report

MrArnoldPalmer left a comment

Choose a reason for hiding this comment

mergify bot commented Mar 3, 2020

aws-cdk-automation commented Mar 3, 2020

AWS CodeBuild CI Report

mergify bot commented Mar 3, 2020