Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codepipeline): allow retrieving created stages and actions #5206

Merged
merged 3 commits into from
Nov 27, 2019
Merged

feat(codepipeline): allow retrieving created stages and actions #5206

merged 3 commits into from
Nov 27, 2019

Conversation

skinny85
Copy link
Contributor

@skinny85 skinny85 commented Nov 27, 2019 •
edited
Loading

This adds a stages property on Pipeline, and actions property on IStage, which makes it easier to mutate the pipeline after it has been created, which is useful when creating L3s.

Fixes #4878

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@skinny85
feat(codepipeline): allow retrieving created stages and actions
706ab1a 
This adds a stages property on Pipeline,
and actions property on IStage,
which makes it easier to mutate the pipeline after it has been created,
which is useful when creating L3s.

Fixes aws#4878
@skinny85 skinny85 self-assigned this Nov 27, 2019
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 27, 2019
@mergify
Copy link
Contributor

mergify bot commented Nov 27, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@skinny85 skinny85 mentioned this pull request Nov 27, 2019
Closed
2 tasks
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: PR description has bad line breaks.

packages/@aws-cdk/aws-codepipeline/lib/stage.ts
@@ -42,17 +42,21 @@ export class Stage implements IStage {
/**
* Get a duplicate of this stage's list of actions.
*/
public get actions(): FullActionDescriptor[] {
public get actionDescriptors(): FullActionDescriptor[] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking change? Why is this even in the public API?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a breaking change - the Stage class is private to the @aws-cdk/aws-codepipeline package.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Nov 27, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a5b056b into aws:master Nov 27, 2019
@skinny85 skinny85 deleted the feat/codepipeline-customizations branch November 27, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@skinny85 skinny85

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand codepipeline.Pipeline public API (and others) for better post-instantiation customizability
3 participants
@skinny85 @aws-cdk-automation @eladb