-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(codebuild): support AL2 2.0 & Standard 3.0 #5226
Conversation
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thanks for the PR @trivikr ! To make the build pass, you need to fix the "all public elements have to have documentation" requirement. You can do it in 2 ways:
"awslint": {
"exclude": [
"docs-public-apis:@aws-cdk/aws-codebuild.LinuxBuildImage.AMAZON_LINUX_2",
"docs-public-apis:@aws-cdk/aws-codebuild.LinuxBuildImage.STANDARD_1_0",
"docs-public-apis:@aws-cdk/aws-codebuild.LinuxBuildImage.STANDARD_2_0",
// ... You need to add the new fields into this list. |
Added the new fields to the list in 6c8c155 |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, thanks @trivikr !
Thank you for contributing! Your pull request is now being automatically merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Closes: #5225
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license