Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codebuild): support AL2 2.0 & Standard 3.0 #5226

Merged
merged 4 commits into from
Nov 27, 2019

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 27, 2019

Closes: #5225


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@trivikr trivikr requested a review from skinny85 as a code owner November 27, 2019 17:58
@mergify
Copy link
Contributor

mergify bot commented Nov 27, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@skinny85
Copy link
Contributor

Thanks for the PR @trivikr !

To make the build pass, you need to fix the "all public elements have to have documentation" requirement. You can do it in 2 ways:

  1. Actually write the docs ;p. Perhaps include a link to CodeBuild's public documentation on these images...?
  2. Ignore these errors, by editing the package.json:
  "awslint": {
    "exclude": [
      "docs-public-apis:@aws-cdk/aws-codebuild.LinuxBuildImage.AMAZON_LINUX_2",
      "docs-public-apis:@aws-cdk/aws-codebuild.LinuxBuildImage.STANDARD_1_0",
      "docs-public-apis:@aws-cdk/aws-codebuild.LinuxBuildImage.STANDARD_2_0",
      // ...

You need to add the new fields into this list.

@trivikr
Copy link
Member Author

trivikr commented Nov 27, 2019

Added the new fields to the list in 6c8c155
As per #4645 (review), the exclusions for all Linux Build images can be removed at once

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks @trivikr !

@mergify
Copy link
Contributor

mergify bot commented Nov 27, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e6ef981 into aws:master Nov 27, 2019
@trivikr trivikr deleted the 5225-codebuild-images branch November 27, 2019 19:36
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AL2 2.0 & Standard 3.0 in CodeBuild
3 participants