Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix the behaviour for the --generate-only flag #5253

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

netroy
Copy link
Contributor

@netroy netroy commented Nov 29, 2019

Settings stores the flag in camelCase.
But, the flag is currently read in kebab-case.

This PR fixes the bug, & adds some tests for expected behavior.

Fixes #5030


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@netroy netroy requested a review from RomainMuller as a code owner November 29, 2019 11:40
@mergify
Copy link
Contributor

mergify bot commented Nov 29, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@mergify mergify bot dismissed shivlaks’s stale review November 29, 2019 12:00

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to confirm one of the PR checklist items did you also re-run the integ tests and verify they all pass?

@netroy
Copy link
Contributor Author

netroy commented Nov 29, 2019

just to confirm one of the PR checklist items did you also re-run the integ tests and verify they all pass?

@shivlaks I did.

@mergify
Copy link
Contributor

mergify bot commented Nov 29, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit ecbe0b6 into aws:master Nov 29, 2019
@netroy netroy deleted the fix-5030 branch November 29, 2019 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Init with --generate-only is not skipping git init or npm install
3 participants