-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): fix the behaviour for the --generate-only
flag
#5253
Conversation
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to confirm one of the PR checklist items did you also re-run the integ tests and verify they all pass?
@shivlaks I did. |
Thank you for contributing! Your pull request is now being automatically merged. |
Settings stores the flag in camelCase.
But, the flag is currently read in kebab-case.
This PR fixes the bug, & adds some tests for expected behavior.
Fixes #5030
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license