Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cloudformation): import CloudFormation resource specification v9.1.1 #5297

Merged
merged 24 commits into from
Dec 8, 2019
Merged

feat(cloudformation): import CloudFormation resource specification v9.1.1 #5297

merged 24 commits into from
Dec 8, 2019

Conversation

shivlaks
Copy link
Contributor

@shivlaks shivlaks commented Dec 4, 2019

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

shivlaks and others added 6 commits November 28, 2019 02:25
@shivlaks
partial import with failures to address
8f01c1f
@rix0rrr
Rewrite incomplete types to "Json"
d664b1f 
Incomplete type definitions are unusable, so we translate them
into "Json" to be able to something semi-useful.

Fix some broken terminology in the specs and code generator.
@shivlaks
replace incomplete types as empty object
7308bc7
@shivlaks
clean up CHANGELOG
a7580b0
@shivlaks
remove conditional flow check for complex types without properties
008990b
@shivlaks
update tests
8232865
@shivlaks shivlaks added the pr/do-not-merge This PR should not be merged at this time. label Dec 4, 2019
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 4, 2019
@mergify
Copy link
Contributor

mergify bot commented Dec 4, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shivlaks shivlaks requested a review from skinny85 as a code owner December 4, 2019 12:57
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shivlaks shivlaks requested a review from SoManyHs as a code owner December 5, 2019 08:56
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jogold jogold mentioned this pull request Dec 5, 2019
Merged
@jgondron jgondron mentioned this pull request Dec 6, 2019
Closed
@shivlaks shivlaks removed the pr/do-not-merge This PR should not be merged at this time. label Dec 8, 2019
@mergify
Copy link
Contributor

mergify bot commented Dec 8, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit 7f33541 into master Dec 8, 2019
@mergify mergify bot deleted the shivlaks/cfn-spec-update branch December 8, 2019 02:54
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jogold jogold mentioned this pull request Dec 8, 2019
Merged
ed-at-work pushed a commit to ed-at-work/aws-cdk that referenced this pull request Dec 17, 2019
@shivlaks
feat(cloudformation): import CloudFormation resource specification v9…
5f03235 
….1.1 (aws#5297)

* partial import with failures to address

* Rewrite incomplete types to "Json"

Incomplete type definitions are unusable, so we translate them
into "Json" to be able to something semi-useful.

Fix some broken terminology in the specs and code generator.

* replace incomplete types as empty object

* clean up CHANGELOG

* remove conditional flow check for complex types without properties

* update tests

* fix codebuild tests

* fix servicediscovery tests

* fix elbv2 targets tests

* fix autoscaling tests

* 1 more autoscaling test - missed spot instances test

* fix appmesh tests

* fix codedeploy tests

* fix eks tests

* fix route53-targets tests

* fix ecs tests

* fix fargate vpc test

* fix events-targets tests

* fix codepipeline-actions tests

* fix ecs-patterns tests

* fix rds tests

* update decdk snapshot
@PatMyron PatMyron mentioned this pull request Feb 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

@eladb eladb Awaiting requested review from eladb

@nija-at nija-at Awaiting requested review from nija-at

@skinny85 skinny85 Awaiting requested review from skinny85

@SoManyHs SoManyHs Awaiting requested review from SoManyHs

Assignees

@eladb eladb

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shivlaks @aws-cdk-automation @rix0rrr @eladb