Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(init-templates): use pytest for Python sample-app init template #5325

Merged
merged 3 commits into from
Dec 11, 2019
Merged

fix(init-templates): use pytest for Python sample-app init template #5325

merged 3 commits into from
Dec 11, 2019

Conversation

shivlaks
Copy link
Contributor

@shivlaks shivlaks commented Dec 6, 2019

Fixes #5313

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 6, 2019
@mergify
Copy link
Contributor

mergify bot commented Dec 6, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

RomainMuller
RomainMuller reviewed Dec 11, 2019
View reviewed changes
packages/aws-cdk/lib/init-templates/sample-app/python/tests/unit/test_%name%_stack.template.py

def test_sqs_queue_created():
assert("AWS::SQS::Queue" in get_template())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those assertions are a little underwhelming

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, let me see if I can verify the full template

@mergify
Copy link
Contributor

mergify bot commented Dec 11, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit 6c25da7 into master Dec 11, 2019
@mergify mergify bot deleted the shivlaks/fix-python-sample-app-tests branch December 11, 2019 21:59
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ed-at-work pushed a commit to ed-at-work/aws-cdk that referenced this pull request Dec 17, 2019
@shivlaks
fix(init-templates): use pytest for Python sample-app init template (a…
bd8e789 
…ws#5325)

* fix(init-templates): use pytest for Python sample-app init template

Fixes aws#5313

* "remove redundant call to get_template"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees

@shivlaks shivlaks

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python sample-app template test examples still point to "HelloConstruct"
3 participants
@shivlaks @aws-cdk-automation @RomainMuller